summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorArmin Ronacher <armin.ronacher@active-4.com>2018-05-11 11:23:46 +0200
committerArmin Ronacher <armin.ronacher@active-4.com>2018-05-11 11:23:46 +0200
commit3f9f93137b09bd0e510709f198fef0981ce83b7c (patch)
tree46b442e2a398fbdbc0a43c6f69571f3f40cf14fb
parent6dbfe1079a3919c6aa4ace467951cb0cf9950cbf (diff)
downloadraven-3f9f93137b09bd0e510709f198fef0981ce83b7c.tar.gz
fix: Always consider remote configs enabled even without secret key. Fixes #1235
-rw-r--r--raven/conf/remote.py2
-rw-r--r--tests/conf/tests.py1
2 files changed, 2 insertions, 1 deletions
diff --git a/raven/conf/remote.py b/raven/conf/remote.py
index 7d9235e..af4cb4b 100644
--- a/raven/conf/remote.py
+++ b/raven/conf/remote.py
@@ -61,7 +61,7 @@ class RemoteConfig(object):
return text_type(self.base_url)
def is_active(self):
- return all([self.base_url, self.project, self.public_key, self.secret_key])
+ return all([self.base_url, self.project, self.public_key])
def get_transport(self):
if not self.store_endpoint:
diff --git a/tests/conf/tests.py b/tests/conf/tests.py
index 6a348bb..333ea55 100644
--- a/tests/conf/tests.py
+++ b/tests/conf/tests.py
@@ -90,6 +90,7 @@ class RemoteConfigTest(TestCase):
assert res.public_key == 'foo'
assert res.secret_key is None
assert res.options == {}
+ assert res.is_active()
assert get_auth_header(protocol=7, timestamp=42,
client='raven-python/1.0',