diff options
author | Markus Unterwaditzer <markus@unterwaditzer.net> | 2018-12-19 11:48:11 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-12-19 11:48:11 +0100 |
commit | 5cff20518c850352033815d0dac64753b39e166b (patch) | |
tree | 2d31b886ebf158de7717ac3a63b25d461560e841 | |
parent | d9e787b7a75ce9e50a3537d379d8a767bab9117f (diff) | |
download | raven-5cff20518c850352033815d0dac64753b39e166b.tar.gz |
fix: Dont serialize nan when present in frame local vars (#1312)
* fix: Dont serialize nan when present in vars
* fix: Simplify float serializer
* fix: Tests
* fix: Convert all numbers to string
-rw-r--r-- | raven/utils/serializer/base.py | 9 | ||||
-rw-r--r-- | tests/base/tests.py | 12 | ||||
-rw-r--r-- | tests/utils/encoding/tests.py | 11 |
3 files changed, 21 insertions, 11 deletions
diff --git a/raven/utils/serializer/base.py b/raven/utils/serializer/base.py index 92b2102..465d0d1 100644 --- a/raven/utils/serializer/base.py +++ b/raven/utils/serializer/base.py @@ -167,21 +167,22 @@ class BooleanSerializer(Serializer): types = (bool,) def serialize(self, value, **kwargs): - return bool(value) + return repr(bool(value)) class FloatSerializer(Serializer): types = (float,) def serialize(self, value, **kwargs): - return float(value) + # Wrap with repr to convert inf/nan to string + return repr(float(value)) class IntegerSerializer(Serializer): types = (int,) def serialize(self, value, **kwargs): - return int(value) + return repr(int(value)) class FunctionSerializer(Serializer): @@ -197,7 +198,7 @@ if PY2: types = (long,) # noqa def serialize(self, value, **kwargs): - return long(value) # noqa + return repr(long(value)) # noqa # register all serializers, order matters diff --git a/tests/base/tests.py b/tests/base/tests.py index df03278..dfaf645 100644 --- a/tests/base/tests.py +++ b/tests/base/tests.py @@ -307,6 +307,18 @@ class ClientTest(TestCase): self.assertEquals(frame['function'], 'test_exception_event') self.assertTrue('timestamp' in event) + def test_exception_nan_in_vars(self): + try: + foo = float("nan") # noqa + raise ValueError("foo") + except ValueError: + self.client.captureException() + + event, = self.client.events + exc, = event['exception']['values'] + frame, = exc['stacktrace']['frames'] + assert frame['vars']['foo'] == "nan" + def test_exception_event_true_exc_info(self): try: raise ValueError('foo') diff --git a/tests/utils/encoding/tests.py b/tests/utils/encoding/tests.py index 50c186a..08f9387 100644 --- a/tests/utils/encoding/tests.py +++ b/tests/utils/encoding/tests.py @@ -65,21 +65,18 @@ class TransformTest(TestCase): def test_float(self): result = transform(13.0) - self.assertEqual(type(result), float) - self.assertEqual(result, 13.0) + self.assertEqual(result, "13.0") def test_bool(self): result = transform(True) - self.assertEqual(type(result), bool) - self.assertEqual(result, True) + self.assertEqual(result, 'True') def test_int_subclass(self): class X(int): pass result = transform(X()) - self.assertEqual(type(result), int) - self.assertEqual(result, 0) + self.assertEqual(result, '0') def test_dict_keys(self): x = {'foo': 'bar'} @@ -176,7 +173,7 @@ class TransformTest(TestCase): def test_list_max_length(self): x = list(range(10)) result = transform(x, list_max_length=3) - self.assertEqual(result, (0, 1, 2)) + self.assertEqual(result, ('0', '1', '2')) def test_dict_max_length(self): x = dict((x, x) for x in range(10)) |