summaryrefslogtreecommitdiff
path: root/requests_cache
diff options
context:
space:
mode:
authorJordan Cook <jordan.cook.git@proton.me>2022-10-20 16:01:38 -0500
committerJordan Cook <jordan.cook.git@proton.me>2022-10-26 12:18:22 -0500
commit75402c5084f02644d8782e0a2a5ea896143e3089 (patch)
tree8f6251b7368f2fb213a7b8b1a8bda53c76f95a48 /requests_cache
parent02c49bdf6d45b0a4963b3a55ec7746acd3dccf02 (diff)
downloadrequests-cache-75402c5084f02644d8782e0a2a5ea896143e3089.tar.gz
Fix backwards-compatibility with deprecated remove_expired_responses
Diffstat (limited to 'requests_cache')
-rw-r--r--requests_cache/backends/base.py4
-rw-r--r--requests_cache/session.py6
2 files changed, 5 insertions, 5 deletions
diff --git a/requests_cache/backends/base.py b/requests_cache/backends/base.py
index 3afe4e7..67f7832 100644
--- a/requests_cache/backends/base.py
+++ b/requests_cache/backends/base.py
@@ -185,7 +185,7 @@ class BaseCache:
invalid: bool = False,
older_than: ExpirationTime = None,
) -> Iterator[CachedResponse]:
- """Get responses from the cache, with optional filters
+ """Get responses from the cache, with optional filters for which responses to include:
Args:
valid: Include valid and unexpired responses; set to ``False`` to get **only**
@@ -298,9 +298,9 @@ class BaseCache:
'please use .delete(expired=True) instead',
DeprecationWarning,
)
- self.delete(expired=True, invalid=True)
if expire_after:
self.reset_expiration(expire_after)
+ self.delete(expired=True, invalid=True)
def values(self, check_expiry: bool = False) -> Iterator[CachedResponse]:
warn('BaseCache.values() is deprecated; please use .filter() instead', DeprecationWarning)
diff --git a/requests_cache/session.py b/requests_cache/session.py
index 3ed7a6d..d94adf8 100644
--- a/requests_cache/session.py
+++ b/requests_cache/session.py
@@ -307,9 +307,9 @@ class CacheMixin(MIXIN_BASE):
super().close()
self.cache.close()
- def remove_expired_responses(self):
- """**Deprecated:** Use ``session.cache.delete(expired=True)`` instead"""
- self.cache.delete(expired=True, invalid=True)
+ def remove_expired_responses(self, expire_after: ExpirationTime = None):
+ # Deprecated; will be replaced by CachedSession.cache.delete(expired=True)
+ self.cache.remove_expired_responses(expire_after)
def __getstate__(self):
# Unlike requests.Session, CachedSession may contain backend connection objects that can't