summaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
authorJordan Cook <jordan.cook.git@proton.me>2023-03-30 19:15:30 -0500
committerJordan Cook <jordan.cook.git@proton.me>2023-04-02 21:42:25 -0500
commitd20f445419529ea0fb5d8c6e851cd7d4cc56f65f (patch)
tree5fb8a42f432cc403069de7ce170ab25881288acf /tests
parenta137fd6b8a8622b6652948ef9567acd080c5dd43 (diff)
downloadrequests-cache-d20f445419529ea0fb5d8c6e851cd7d4cc56f65f.tar.gz
Don't normalize CachedResponse.url when redacting ignored params
Diffstat (limited to 'tests')
-rw-r--r--tests/unit/test_cache_keys.py22
1 files changed, 20 insertions, 2 deletions
diff --git a/tests/unit/test_cache_keys.py b/tests/unit/test_cache_keys.py
index 40cca7f..3e2f243 100644
--- a/tests/unit/test_cache_keys.py
+++ b/tests/unit/test_cache_keys.py
@@ -4,9 +4,14 @@ This just contains tests for some extra edge cases not covered elsewhere.
import json
import pytest
-from requests import Request
+from requests import Request, Response
-from requests_cache.cache_keys import MAX_NORM_BODY_SIZE, create_key, normalize_request
+from requests_cache.cache_keys import (
+ MAX_NORM_BODY_SIZE,
+ create_key,
+ normalize_request,
+ redact_response,
+)
CACHE_KEY = 'e25f7e6326966e82'
@@ -61,6 +66,19 @@ def test_create_key__normalize_duplicate_params():
assert create_key(request_1) == create_key(request_2)
+def test_redact_response__escaped_params():
+ """Test that redact_response() handles escaped request parameters"""
+ request = Request(
+ method='GET',
+ url='https://img.site.com/base/img.jpg?ignored_param=value_1&param_2=value_2',
+ )
+ response = Response()
+ response.url = 'https://img.site.com/base/img.jpg?where=code%3D123'
+ response.request = request
+ redacted_response = redact_response(response, [])
+ assert redacted_response.url == 'https://img.site.com/base/img.jpg?where=code%3D123'
+
+
def test_normalize_request__json_body():
request = Request(
method='GET',