summaryrefslogtreecommitdiff
path: root/migrate/tests/fixture/database.py
diff options
context:
space:
mode:
authorRoman Podolyaka <rpodolyaka@mirantis.com>2013-08-06 17:20:38 +0300
committerGerrit Code Review <review@openstack.org>2013-10-12 07:04:33 +0000
commita91766a1ac86e432449aa66ae8f4b0f886b33e88 (patch)
tree32a8b6aede75f7cfc0c321e4cb4fc44dce0c7cbb /migrate/tests/fixture/database.py
parent838c1cbb147550a39bf2ee35ec1fd5911358ad70 (diff)
downloadsqalchemy-migrate-a91766a1ac86e432449aa66ae8f4b0f886b33e88.tar.gz
Run tests on PostgreSQL and MySQL too
In addition to running tests with different Python and SQLAlchemy versions, they should also be run on different DB backends, which are used in production (PostgreSQL and MySQL). This patch: - modifies test_db.cfg to run tests on PostgreSQL and MySQL (Jenkins Slave credentials are used here, to ensure these tests are always run by Jenkins gate); if a backend is not available, test cases will be skipped for it - concurrency is set to 1 (sharing of the one MySQL or PostgreSQL DB among different test runner processes would lead to race conditions) - fixes tests dropping FK columns in MySQL: in earlier MySQL versions dropping a column that is a part of a FK constraint would lead to dropping of the FK too. As of MySQL 5.5 that's not the case anymore: if one tries to drop such column, he/she will get a very obscure error (something like "Error on rename of './openstack_citest/#sql-4af_aa2' to './openstack_citest/tmp_adddropcol' (errno: 150)") '\nALTER TABLE tmp_adddropcol DROP COLUMN r2'). So the solution if to drop FK constraints first, and only then the columns it is made up of Change-Id: I8c5d2874c83e7df46da69969ed54d85437c849e7
Diffstat (limited to 'migrate/tests/fixture/database.py')
-rw-r--r--migrate/tests/fixture/database.py19
1 files changed, 12 insertions, 7 deletions
diff --git a/migrate/tests/fixture/database.py b/migrate/tests/fixture/database.py
index b9eb0ca..e000d60 100644
--- a/migrate/tests/fixture/database.py
+++ b/migrate/tests/fixture/database.py
@@ -6,6 +6,7 @@ import logging
from decorator import decorator
from sqlalchemy import create_engine, Table, MetaData
+from sqlalchemy import exc as sa_exc
from sqlalchemy.orm import create_session
from sqlalchemy.pool import StaticPool
@@ -81,13 +82,17 @@ def usedb(supported=None, not_supported=None):
try:
log.debug("Running test with engine %s", url)
try:
- try:
- self._setup(url)
- except Exception,e:
- setup_exception=e
- else:
- setup_exception=None
- f(self, *a, **kw)
+ self._setup(url)
+ except sa_exc.OperationalError:
+ log.info('Backend %s is not available, skip it', url)
+ continue
+ except Exception as e:
+ setup_exception = e
+ else:
+ setup_exception = None
+
+ try:
+ f(self, *a, **kw)
finally:
try:
self._teardown()