diff options
Diffstat (limited to 'migrate/changeset/databases')
| -rw-r--r-- | migrate/changeset/databases/__init__.py | 2 | ||||
| -rw-r--r-- | migrate/changeset/databases/oracle.py | 6 | ||||
| -rw-r--r-- | migrate/changeset/databases/visitor.py | 4 |
3 files changed, 5 insertions, 7 deletions
diff --git a/migrate/changeset/databases/__init__.py b/migrate/changeset/databases/__init__.py index 4abc187..8546918 100644 --- a/migrate/changeset/databases/__init__.py +++ b/migrate/changeset/databases/__init__.py @@ -2,7 +2,7 @@ This module contains database dialect specific changeset implementations. """ -__all__=[ +__all__ = [ 'postgres', 'sqlite', 'mysql', diff --git a/migrate/changeset/databases/oracle.py b/migrate/changeset/databases/oracle.py index abdaad8..59e266e 100644 --- a/migrate/changeset/databases/oracle.py +++ b/migrate/changeset/databases/oracle.py @@ -42,16 +42,14 @@ class OracleSchemaChanger(OracleSchemaGenerator, ansisql.ANSISchemaChanger): def _visit_column_change(self, table, col_name, delta): if not hasattr(delta, 'result_column'): - # Oracle needs the whole column definition, not just a - # lone name/type + # Oracle needs the whole column definition, not just a lone name/type raise exceptions.NotSupportedError( "A column object is required to do this") column = delta.result_column # Oracle cannot drop a default once created, but it can set it # to null. We'll do that if default=None - # http://forums.oracle.com/forums/message.jspa?\ - # messageID=1273234#1273234 + # http://forums.oracle.com/forums/message.jspa?messageID=1273234#1273234 dropdefault_hack = (column.server_default is None \ and 'server_default' in delta.keys()) # Oracle apparently doesn't like it when we say "not null" if diff --git a/migrate/changeset/databases/visitor.py b/migrate/changeset/databases/visitor.py index 2f282c7..8a084fb 100644 --- a/migrate/changeset/databases/visitor.py +++ b/migrate/changeset/databases/visitor.py @@ -8,7 +8,7 @@ from migrate.changeset.databases import sqlite, postgres, mysql, oracle # Map SA dialects to the corresponding Migrate extensions -dialects = { +DIALECTS = { sa.engine.default.DefaultDialect: ansisql.ANSIDialect, sa.databases.sqlite.SQLiteDialect: sqlite.SQLiteDialect, sa.databases.postgres.PGDialect: postgres.PGDialect, @@ -43,7 +43,7 @@ def get_dialect_visitor(sa_dialect, name): # map sa dialect to migrate dialect and return visitor sa_dialect_cls = sa_dialect.__class__ - migrate_dialect_cls = dialects[sa_dialect_cls] + migrate_dialect_cls = DIALECTS[sa_dialect_cls] visitor = getattr(migrate_dialect_cls, name) # bind preparer |