summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorjakeogh <github.com@v6y.net>2015-06-27 18:48:46 +0000
committerjakeogh <github.com@v6y.net>2015-06-27 18:48:46 +0000
commit85ebe01349e0b4314d9e25cacc6701d6fed7b87e (patch)
tree051d0ba290a3f5407922b86cc2c0de3eae0d849b
parentad7caa69884bddf6f35da2facc516ab08904c71e (diff)
downloadsqlalchemy-85ebe01349e0b4314d9e25cacc6701d6fed7b87e.tar.gz
add NO MINVALUE and NO MAXVALUE support to Sequence()
-rw-r--r--lib/sqlalchemy/engine/interfaces.py3
-rw-r--r--lib/sqlalchemy/sql/compiler.py4
-rw-r--r--lib/sqlalchemy/sql/schema.py4
-rw-r--r--test/sql/test_defaults.py12
4 files changed, 20 insertions, 3 deletions
diff --git a/lib/sqlalchemy/engine/interfaces.py b/lib/sqlalchemy/engine/interfaces.py
index 1779f6d48..9a31f05ae 100644
--- a/lib/sqlalchemy/engine/interfaces.py
+++ b/lib/sqlalchemy/engine/interfaces.py
@@ -252,7 +252,8 @@ class Dialect(object):
sequence
a dictionary of the form
- {'name' : str, 'start' :int, 'increment': int, 'minvalue': int, 'maxvalue': int}
+ {'name' : str, 'start' :int, 'increment': int, 'minvalue': int,
+ 'maxvalue': int, 'nominvalue': bool, 'nomaxvalue': bool}
Additional column attributes may be present.
"""
diff --git a/lib/sqlalchemy/sql/compiler.py b/lib/sqlalchemy/sql/compiler.py
index b3fee60ec..f7aa02105 100644
--- a/lib/sqlalchemy/sql/compiler.py
+++ b/lib/sqlalchemy/sql/compiler.py
@@ -2303,6 +2303,10 @@ class DDLCompiler(Compiled):
text += " MINVALUE %d" % create.element.minvalue
if create.element.maxvalue is not None:
text += " MAXVALUE %d" % create.element.maxvalue
+ if create.element.nominvalue is not None:
+ text += " NO MINVALUE" % create.element.nominvalue
+ if create.element.nomaxvalue is not None:
+ text += " NO MAXVALUE" % create.element.nomaxvalue
return text
def visit_drop_sequence(self, drop):
diff --git a/lib/sqlalchemy/sql/schema.py b/lib/sqlalchemy/sql/schema.py
index ef84d2680..ccec74a35 100644
--- a/lib/sqlalchemy/sql/schema.py
+++ b/lib/sqlalchemy/sql/schema.py
@@ -2041,8 +2041,8 @@ class Sequence(DefaultGenerator):
is_sequence = True
def __init__(self, name, start=None, increment=None, minvalue=None,
- maxvalue=None, schema=None, optional=False, quote=None,
- metadata=None, quote_schema=None,
+ maxvalue=None, nominvalue=None, nomaxvalue=None, schema=None,
+ optional=False, quote=None, metadata=None, quote_schema=None,
for_update=False):
"""Construct a :class:`.Sequence` object.
diff --git a/test/sql/test_defaults.py b/test/sql/test_defaults.py
index b218aa53f..53eb6c500 100644
--- a/test/sql/test_defaults.py
+++ b/test/sql/test_defaults.py
@@ -805,6 +805,18 @@ class SequenceDDLTest(fixtures.TestBase, testing.AssertsCompiledSQL):
)
self.assert_compile(
+ CreateSequence(Sequence(
+ 'foo_seq', increment=2, start=1, nomaxvalue=True)),
+ "CREATE SEQUENCE foo_seq INCREMENT BY 2 START WITH 0 NO MAXVALUE",
+ )
+
+ self.assert_compile(
+ CreateSequence(Sequence(
+ 'foo_seq', increment=2, start=0, nominvalue=True)),
+ "CREATE SEQUENCE foo_seq INCREMENT BY 2 START WITH 0 NO MINVALUE",
+ )
+
+ self.assert_compile(
DropSequence(Sequence('foo_seq')),
"DROP SEQUENCE foo_seq",
)