postgres oids say byebye by default, putting hooks in for engines to determine column defaults externally to it having a 'default' property, beefed up unittests to support inserts with/without defaults (will fix oracle unit tests too)

1 files changed, 9 insertions, 2 deletions

diff --git a/lib/sqlalchemy/ansisql.py b/lib/sqlalchemy/ansisql.py
index a06abe598..bcd20349b 100644
--- a/lib/sqlalchemy/ansisql.py
+++ b/lib/sqlalchemy/ansisql.py
@@ -370,18 +370,25 @@ class ANSICompiler(sql.Compiled):
         """called when visiting an Insert statement, for each column in the table that
         contains a Sequence object."""
         pass
+    
+    def visit_insert_column(selef, column):
+        """called when visiting an Insert statement, for each column in the table
+        that is a NULL insert into the table"""
+        pass
         
     def visit_insert(self, insert_stmt):
         # set up a call for the defaults and sequences inside the table
         class DefaultVisitor(schema.SchemaVisitor):
+            def visit_column(s, c):
+                self.visit_insert_column(c)
             def visit_column_default(s, cd):
                 self.visit_insert_column_default(c, cd)
             def visit_sequence(s, seq):
                 self.visit_insert_sequence(c, seq)
         vis = DefaultVisitor()
         for c in insert_stmt.table.c:
-            if (self.parameters is None or self.parameters.get(c.key, None) is None) and c.default is not None:
-                c.default.accept_visitor(vis)
+            if (self.parameters is None or self.parameters.get(c.key, None) is None):
+                c.accept_visitor(vis)
         
         self.isinsert = True
         colparams = self._get_colparams(insert_stmt)