diff options
author | Mike Bayer <mike_mp@zzzcomputing.com> | 2023-03-03 09:30:58 -0500 |
---|---|---|
committer | Mike Bayer <mike_mp@zzzcomputing.com> | 2023-03-04 23:22:20 -0500 |
commit | b38fb59fe484d6e4e5992c9b2dc9b9f7724f016a (patch) | |
tree | 21bac11da9981fe45b20bdb06240b37fb47b5800 /lib/sqlalchemy/dialects/mssql/pymssql.py | |
parent | 7099dd20e90307237240f30d5db0816a08356a5b (diff) | |
download | sqlalchemy-b38fb59fe484d6e4e5992c9b2dc9b9f7724f016a.tar.gz |
audition pymssql once more; retire sane_rowcount_returning
pymssql seems to be maintained again and seems to be working
completely, so let's try re-enabling it.
Fixed issue in the new :class:`.Uuid` datatype which prevented it from
working with the pymssql driver. As pymssql seems to be maintained again,
restored testing support for pymssql.
Tweaked the pymssql dialect to take better advantage of
RETURNING for INSERT statements in order to retrieve last inserted primary
key values, in the same way as occurs for the mssql+pyodbc dialect right
now.
Identified that the ``sqlite`` and ``mssql+pyodbc`` dialects are now
compatible with the SQLAlchemy ORM's "versioned rows" feature, since
SQLAlchemy now computes rowcount for a RETURNING statement in this specific
case by counting the rows returned, rather than relying upon
``cursor.rowcount``. In particular, the ORM versioned rows use case
(documented at :ref:`mapper_version_counter`) should now be fully
supported with the SQL Server pyodbc dialect.
Change-Id: I38a0666587212327aecf8f98e86031ab25d1f14d
References: #5321
Fixes: #9414
Diffstat (limited to 'lib/sqlalchemy/dialects/mssql/pymssql.py')
-rw-r--r-- | lib/sqlalchemy/dialects/mssql/pymssql.py | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/lib/sqlalchemy/dialects/mssql/pymssql.py b/lib/sqlalchemy/dialects/mssql/pymssql.py index 699f61714..3823db91b 100644 --- a/lib/sqlalchemy/dialects/mssql/pymssql.py +++ b/lib/sqlalchemy/dialects/mssql/pymssql.py @@ -16,10 +16,9 @@ pymssql is a Python module that provides a Python DBAPI interface around `FreeTDS <https://www.freetds.org/>`_. -.. note:: +.. versionchanged:: 2.0.5 - pymssql is currently not included in SQLAlchemy's continuous integration - (CI) testing. + pymssql was restored to SQLAlchemy's continuous integration testing """ # noqa @@ -51,6 +50,7 @@ class MSIdentifierPreparer_pymssql(MSIdentifierPreparer): class MSDialect_pymssql(MSDialect): supports_statement_cache = True supports_native_decimal = True + supports_native_uuid = True driver = "pymssql" preparer = MSIdentifierPreparer_pymssql |