summaryrefslogtreecommitdiff
path: root/lib/sqlalchemy/dialects/mysql/provision.py
diff options
context:
space:
mode:
authorGeorg Richter <georg@mariadb.com>2020-08-20 08:00:14 -0400
committerMike Bayer <mike_mp@zzzcomputing.com>2020-08-31 18:19:35 -0400
commit603f7d30f68ecd515b57ce902fb12bbbebdca453 (patch)
tree6d4a608cec70c12c067b3f52ae0a338c2ee1cce9 /lib/sqlalchemy/dialects/mysql/provision.py
parent1613c9fb2555eec8f922595304080286f72e6dc4 (diff)
downloadsqlalchemy-603f7d30f68ecd515b57ce902fb12bbbebdca453.tar.gz
MariaDB dialect implementation
Fixes: #5459 Closes: #5515 Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/5515 Pull-request-sha: 760090b9067304cc65fece12fcf10b522afc4a2a Change-Id: I30e8fbc02b7b5329ca228cd39f6fb7cfd0e43092
Diffstat (limited to 'lib/sqlalchemy/dialects/mysql/provision.py')
-rw-r--r--lib/sqlalchemy/dialects/mysql/provision.py12
1 files changed, 12 insertions, 0 deletions
diff --git a/lib/sqlalchemy/dialects/mysql/provision.py b/lib/sqlalchemy/dialects/mysql/provision.py
index a1d82222d..c1d83bbb7 100644
--- a/lib/sqlalchemy/dialects/mysql/provision.py
+++ b/lib/sqlalchemy/dialects/mysql/provision.py
@@ -10,6 +10,18 @@ from ...testing.provision import temp_table_keyword_args
def generate_driver_url(url, driver, query_str):
backend = url.get_backend_name()
+ # NOTE: at the moment, tests are running mariadbconnector
+ # against both mariadb and mysql backends. if we want this to be
+ # limited, do the decisionmaking here to reject a "mysql+mariadbconnector"
+ # URL. Optionally also re-enable the module level
+ # MySQLDialect_mariadbconnector.is_mysql flag as well, which must include
+ # a unit and/or functional test.
+
+ # all the Jenkins tests have been running mysqlclient Python library
+ # built against mariadb client drivers for years against all MySQL /
+ # MariaDB versions going back to MySQL 5.6, currently they can talk
+ # to MySQL databases without problems.
+
if backend == "mysql":
dialect_cls = url.get_dialect()
if dialect_cls._is_mariadb_from_url(url):