diff options
author | Gord Thompson <gord@gordthompson.com> | 2019-10-03 18:18:54 -0400 |
---|---|---|
committer | sqla-tester <sqla-tester@sqlalchemy.org> | 2019-10-03 18:18:54 -0400 |
commit | f94940e4d88b4011fd089bed37cebb76acb1a385 (patch) | |
tree | f728271a6bdfb8627d53f2c325d388f79b6a34c6 /lib/sqlalchemy/dialects/mysql/pyodbc.py | |
parent | 3836a90dcf9b202db2eb8f013b8eca07245067be (diff) | |
download | sqlalchemy-f94940e4d88b4011fd089bed37cebb76acb1a385.tar.gz |
fix error in test_round_trip for TimeTest with mysql+pyodbc
Fixes: #4879
### Description
create mysql+pyodbc-specific `_pyodbcTIME` class to avoid error thrown by `result_processor` in the (more) generic mysql/types.py.
### Checklist
<!-- go over following points. check them with an `x` if they do apply, (they turn into clickable checkboxes once the PR is submitted, so no need to do everything at once)
-->
This pull request is:
- [ ] A documentation / typographical error fix
- Good to go, no issue or tests are needed
- [x] A short code fix
- please include the issue number, and create an issue if none exists, which
must include a complete example of the issue. one line code fixes without an
issue and demonstration will not be accepted.
- Please include: `Fixes: #<issue number>` in the commit message
- please include tests. one line code fixes without tests will not be accepted.
- [ ] A new feature implementation
- please include the issue number, and create an issue if none exists, which must
include a complete example of how the feature would look.
- Please include: `Fixes: #<issue number>` in the commit message
- please include tests.
**Have a nice day!**
Closes: #4880
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/4880
Pull-request-sha: 2e4c468c3ad685d6573e0d9755ba97a28df50b6c
Change-Id: Ib5c5b0971969c2a9870b7f43d06703618cfc56f7
Diffstat (limited to 'lib/sqlalchemy/dialects/mysql/pyodbc.py')
-rw-r--r-- | lib/sqlalchemy/dialects/mysql/pyodbc.py | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/lib/sqlalchemy/dialects/mysql/pyodbc.py b/lib/sqlalchemy/dialects/mysql/pyodbc.py index 17021812c..6866c3f42 100644 --- a/lib/sqlalchemy/dialects/mysql/pyodbc.py +++ b/lib/sqlalchemy/dialects/mysql/pyodbc.py @@ -26,8 +26,19 @@ import re from .base import MySQLDialect from .base import MySQLExecutionContext +from .types import TIME from ... import util from ...connectors.pyodbc import PyODBCConnector +from ...sql.sqltypes import Time + + +class _pyodbcTIME(TIME): + def result_processor(self, dialect, coltype): + def process(value): + # pyodbc returns a datetime.time object; no need to convert + return value + + return process class MySQLExecutionContext_pyodbc(MySQLExecutionContext): @@ -40,6 +51,7 @@ class MySQLExecutionContext_pyodbc(MySQLExecutionContext): class MySQLDialect_pyodbc(PyODBCConnector, MySQLDialect): + colspecs = util.update_copy(MySQLDialect.colspecs, {Time: _pyodbcTIME}) supports_unicode_statements = False execution_ctx_cls = MySQLExecutionContext_pyodbc |