summaryrefslogtreecommitdiff
path: root/lib/sqlalchemy/dialects/oracle/base.py
diff options
context:
space:
mode:
authorMike Bayer <mike_mp@zzzcomputing.com>2009-10-15 16:09:59 +0000
committerMike Bayer <mike_mp@zzzcomputing.com>2009-10-15 16:09:59 +0000
commitbc351a2dc423987f05f4bf88db4987be507ee0a1 (patch)
tree9f6f8c8ab74abfa8d2d03690178693d0412ca462 /lib/sqlalchemy/dialects/oracle/base.py
parentad89932715193275d37b5e22b830f092e350b1fe (diff)
downloadsqlalchemy-bc351a2dc423987f05f4bf88db4987be507ee0a1.tar.gz
- DefaultRunner and subclasses have been removed. The job
of this object has been simplified and moved into ExecutionContext. Dialects which support sequences should add a `fire_sequence()` method to their execution context implementation. [ticket:1566]
Diffstat (limited to 'lib/sqlalchemy/dialects/oracle/base.py')
-rw-r--r--lib/sqlalchemy/dialects/oracle/base.py15
1 files changed, 8 insertions, 7 deletions
diff --git a/lib/sqlalchemy/dialects/oracle/base.py b/lib/sqlalchemy/dialects/oracle/base.py
index c14151515..4f37412eb 100644
--- a/lib/sqlalchemy/dialects/oracle/base.py
+++ b/lib/sqlalchemy/dialects/oracle/base.py
@@ -454,12 +454,6 @@ class OracleDDLCompiler(compiler.DDLCompiler):
return text
-class OracleDefaultRunner(base.DefaultRunner):
- def visit_sequence(self, seq):
- return self.execute_string("SELECT " +
- self.dialect.identifier_preparer.format_sequence(seq) +
- ".nextval FROM DUAL", ())
-
class OracleIdentifierPreparer(compiler.IdentifierPreparer):
reserved_words = set([x.lower() for x in RESERVED_WORDS])
@@ -477,6 +471,13 @@ class OracleIdentifierPreparer(compiler.IdentifierPreparer):
name = re.sub(r'^_+', '', savepoint.ident)
return super(OracleIdentifierPreparer, self).format_savepoint(savepoint, name)
+
+class OracleExecutionContext(default.DefaultExecutionContext):
+ def fire_sequence(self, seq):
+ return self._execute_scalar("SELECT " +
+ self.dialect.identifier_preparer.format_sequence(seq) +
+ ".nextval FROM DUAL")
+
class OracleDialect(default.DefaultDialect):
name = 'oracle'
supports_alter = True
@@ -502,7 +503,7 @@ class OracleDialect(default.DefaultDialect):
ddl_compiler = OracleDDLCompiler
type_compiler = OracleTypeCompiler
preparer = OracleIdentifierPreparer
- defaultrunner = OracleDefaultRunner
+ execution_ctx_cls = OracleExecutionContext
reflection_options = ('oracle_resolve_synonyms', )