summaryrefslogtreecommitdiff
path: root/lib/sqlalchemy/dialects/postgresql
diff options
context:
space:
mode:
authorMike Bayer <mike_mp@zzzcomputing.com>2023-04-08 18:43:31 -0400
committerMike Bayer <mike_mp@zzzcomputing.com>2023-04-08 18:45:31 -0400
commit8128a8f3638b522778458edb81c81e654927bea4 (patch)
tree3e5fab30b47e490a1faefc6d06d9611b4e23fb97 /lib/sqlalchemy/dialects/postgresql
parent0cb1e5d08d3ec448c2b318966a675c963cd12aa0 (diff)
downloadsqlalchemy-8128a8f3638b522778458edb81c81e654927bea4.tar.gz
fix pg ENUM issues
Restored the :paramref:`_postgresql.ENUM.name` parameter as optional in the signature for :class:`_postgresql.ENUM`, as this is chosen automatically from a given pep-435 ``Enum`` type. Fixed issue where the comparison for :class:`_postgresql.ENUM` against a plain string would cast that right-hand side type as VARCHAR, which due to more explicit casting added to dialects such as asyncpg would produce a PostgreSQL type mismatch error. Fixes: #9611 Fixes: #9621 Change-Id: If095544cd1a52016ad2e7cfa2d70c919a94e79c1
Diffstat (limited to 'lib/sqlalchemy/dialects/postgresql')
-rw-r--r--lib/sqlalchemy/dialects/postgresql/named_types.py23
1 files changed, 21 insertions, 2 deletions
diff --git a/lib/sqlalchemy/dialects/postgresql/named_types.py b/lib/sqlalchemy/dialects/postgresql/named_types.py
index e2a683e18..b0427b569 100644
--- a/lib/sqlalchemy/dialects/postgresql/named_types.py
+++ b/lib/sqlalchemy/dialects/postgresql/named_types.py
@@ -20,6 +20,7 @@ from ...sql import elements
from ...sql import roles
from ...sql import sqltypes
from ...sql import type_api
+from ...sql.base import _NoArg
from ...sql.ddl import InvokeCreateDDLBase
from ...sql.ddl import InvokeDropDDLBase
@@ -244,7 +245,13 @@ class ENUM(NamedType, sqltypes.NativeForEmulated, sqltypes.Enum):
DDLGenerator = EnumGenerator
DDLDropper = EnumDropper
- def __init__(self, *enums, name: str, create_type: bool = True, **kw):
+ def __init__(
+ self,
+ *enums,
+ name: Union[str, _NoArg, None] = _NoArg.NO_ARG,
+ create_type: bool = True,
+ **kw,
+ ):
"""Construct an :class:`_postgresql.ENUM`.
Arguments are the same as that of
@@ -280,7 +287,19 @@ class ENUM(NamedType, sqltypes.NativeForEmulated, sqltypes.Enum):
"non-native enum."
)
self.create_type = create_type
- super().__init__(*enums, name=name, **kw)
+ if name is not _NoArg.NO_ARG:
+ kw["name"] = name
+ super().__init__(*enums, **kw)
+
+ def coerce_compared_value(self, op, value):
+ super_coerced_type = super().coerce_compared_value(op, value)
+ if (
+ super_coerced_type._type_affinity
+ is type_api.STRINGTYPE._type_affinity
+ ):
+ return self
+ else:
+ return super_coerced_type
@classmethod
def __test_init__(cls):