summaryrefslogtreecommitdiff
path: root/lib/sqlalchemy/orm/mapper.py
diff options
context:
space:
mode:
authorMike Bayer <mike_mp@zzzcomputing.com>2022-04-11 22:03:28 -0400
committerMike Bayer <mike_mp@zzzcomputing.com>2022-04-11 22:05:42 -0400
commit8254e3a28a32b7097fb926a373c17c35d4ec1d57 (patch)
treef86ff35c2fe9213f9be75c7e1b371710801606bf /lib/sqlalchemy/orm/mapper.py
parent11bf82447438a9d5d9df9d613bf245694d6120dc (diff)
downloadsqlalchemy-8254e3a28a32b7097fb926a373c17c35d4ec1d57.tar.gz
repair ancient and incorrect comment
it referred towards _columntoproperty refering to lists of MapperProperty. this comment goes all the way to pre 0.1 being released. it's likely been wrong for nearly all that time. Change-Id: I71234ae58a6253249d92224356e38372e4aff148
Diffstat (limited to 'lib/sqlalchemy/orm/mapper.py')
-rw-r--r--lib/sqlalchemy/orm/mapper.py10
1 files changed, 3 insertions, 7 deletions
diff --git a/lib/sqlalchemy/orm/mapper.py b/lib/sqlalchemy/orm/mapper.py
index e463dcdb5..982b4b6d9 100644
--- a/lib/sqlalchemy/orm/mapper.py
+++ b/lib/sqlalchemy/orm/mapper.py
@@ -1407,19 +1407,14 @@ class Mapper(
)
def _configure_properties(self):
- # Column and other ClauseElement objects which are mapped
- # TODO: technically this should be a DedupeColumnCollection
- # however DCC needs changes and more tests to fully cover
- # storing columns under a separate key name
+ # TODO: consider using DedupeColumnCollection
self.columns = self.c = sql_base.ColumnCollection()
# object attribute names mapped to MapperProperty objects
self._props = util.OrderedDict()
- # table columns mapped to lists of MapperProperty objects
- # using a list allows a single column to be defined as
- # populating multiple object attributes
+ # table columns mapped to MapperProperty
self._columntoproperty = _ColumnMapping(self)
# load custom properties
@@ -3609,6 +3604,7 @@ class _ColumnMapping(dict):
__slots__ = ("mapper",)
def __init__(self, mapper):
+ # TODO: weakref would be a good idea here
self.mapper = mapper
def __missing__(self, column):