diff options
| author | Carson Ip <carsonip715@gmail.com> | 2020-01-03 17:09:20 -0500 |
|---|---|---|
| committer | Mike Bayer <mike_mp@zzzcomputing.com> | 2020-01-04 13:01:26 -0500 |
| commit | 5ecb7732fb62d80adb4434bdd0e606e43aa14a98 (patch) | |
| tree | 62f4110b11eda3228dd01d935535480c18276a01 /lib/sqlalchemy/orm/query.py | |
| parent | 5881fd274015af3de37f2ff0f91ff6a7c61c1540 (diff) | |
| download | sqlalchemy-5ecb7732fb62d80adb4434bdd0e606e43aa14a98.tar.gz | |
Fix QueryContext ref cycle on joinedload
Avoid storing a reference to itself when dealing with create_eager_joins. Also fix a cheating test.
Fixes: #5071
Closes: #5072
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/5072
Pull-request-sha: 75ebaf7c91e96d7567eb5760be713dc134c58763
Change-Id: I511ddc0979b46f7928217347199eca4b1d0b4a49
Diffstat (limited to 'lib/sqlalchemy/orm/query.py')
| -rw-r--r-- | lib/sqlalchemy/orm/query.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/sqlalchemy/orm/query.py b/lib/sqlalchemy/orm/query.py index e69ebde56..5f799cc68 100644 --- a/lib/sqlalchemy/orm/query.py +++ b/lib/sqlalchemy/orm/query.py @@ -3878,7 +3878,7 @@ class Query(Generative): for rec in context.create_eager_joins: strategy = rec[0] - strategy(*rec[1:]) + strategy(context, *rec[1:]) if context.from_clause: # "load from explicit FROMs" mode, |