diff options
| author | Mike Bayer <mike_mp@zzzcomputing.com> | 2016-10-20 10:24:40 -0400 |
|---|---|---|
| committer | Mike Bayer <mike_mp@zzzcomputing.com> | 2016-10-20 14:14:50 -0400 |
| commit | 30bd28fca2091e4b2b093154a14c668c09ae3ccd (patch) | |
| tree | 3fe9647770d95e31f0a4cb2695ae9738cf6df372 /lib/sqlalchemy/sql/base.py | |
| parent | 39ac19510989390dddf7a51f65ec7c8830ec04d1 (diff) | |
| download | sqlalchemy-30bd28fca2091e4b2b093154a14c668c09ae3ccd.tar.gz | |
Ensure TypeDecorator delegates _set_parent_with_dispatch
Ensure TypeDecorator delegates _set_parent_with_dispatch as well as
_set_parent to itself as well as its impl, as the TypeDecorator
class itself may have an active SchemaType implementation as well.
Fixed regression which occurred as a side effect of :ticket:`2919`,
which in the less typical case of a user-defined
:class:`.TypeDecorator` that was also itself an instance of
:class:`.SchemaType` (rather than the implementation being such)
would cause the column attachment events to be skipped for the
type itself.
Change-Id: I0afb498fd91ab7d948e4439e7323a89eafcce0bc
Fixes: #3832
Diffstat (limited to 'lib/sqlalchemy/sql/base.py')
| -rw-r--r-- | lib/sqlalchemy/sql/base.py | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/lib/sqlalchemy/sql/base.py b/lib/sqlalchemy/sql/base.py index cf7dcfd31..0b036847b 100644 --- a/lib/sqlalchemy/sql/base.py +++ b/lib/sqlalchemy/sql/base.py @@ -426,8 +426,6 @@ class SchemaEventTarget(object): def _set_parent(self, parent): """Associate with this SchemaEvent's parent object.""" - raise NotImplementedError() - def _set_parent_with_dispatch(self, parent): self.dispatch.before_parent_attach(self, parent) self._set_parent(parent) |