diff options
author | Mike Bayer <mike_mp@zzzcomputing.com> | 2021-11-22 14:28:26 -0500 |
---|---|---|
committer | Mike Bayer <mike_mp@zzzcomputing.com> | 2021-11-23 16:52:55 -0500 |
commit | 939de240d31a5441ad7380738d410a976d4ecc3a (patch) | |
tree | e5261a905636fa473760b1e81894453112bbaa66 /lib/sqlalchemy/sql/compiler.py | |
parent | d3a4e96196cd47858de072ae589c6554088edc24 (diff) | |
download | sqlalchemy-939de240d31a5441ad7380738d410a976d4ecc3a.tar.gz |
propose emulated setinputsizes embedded in the compiler
Add a new system so that PostgreSQL and other dialects have a
reliable way to add casts to bound parameters in SQL statements,
replacing previous use of setinputsizes() for PG dialects.
rationale:
1. psycopg3 will be using the same SQLAlchemy-side "setinputsizes"
as asyncpg, so we will be seeing a lot more of this
2. the full rendering that SQLAlchemy's compilation is performing
is in the engine log as well as error messages. Without this,
we introduce three levels of SQL rendering, the compiler, the
hidden "setinputsizes" in SQLAlchemy, and then whatever the DBAPI
driver does. With this new approach, users reporting bugs etc.
will be less confused that there are as many as two separate
layers of "hidden rendering"; SQLAlchemy's rendering is again
fully transparent
3. calling upon a setinputsizes() method for every statement execution
is expensive. this way, the work is done behind the caching layer
4. for "fast insertmany()", I also want there to be a fast approach
towards setinputsizes. As it was, we were going to be taking
a SQL INSERT with thousands of bound parameter placeholders and
running a whole second pass on it to apply typecasts. this way,
we will at least be able to build the SQL string once without a huge
second pass over the whole string
5. psycopg2 can use this same system for its ARRAY casts
6. the general need for PostgreSQL to have lots of type casts
is now mostly in the base PostgreSQL dialect and works independently
of a DBAPI being present. dependence on DBAPI symbols that aren't
complete / consistent / hashable is removed
I was originally going to try to build this into bind_expression(),
but it was revealed this worked poorly with custom bind_expression()
as well as empty sets. the current impl also doesn't need to
run a second expression pass over the POSTCOMPILE sections, which
came out better than I originally thought it would.
Change-Id: I363e6d593d059add7bcc6d1f6c3f91dd2e683c0c
Diffstat (limited to 'lib/sqlalchemy/sql/compiler.py')
-rw-r--r-- | lib/sqlalchemy/sql/compiler.py | 115 |
1 files changed, 62 insertions, 53 deletions
diff --git a/lib/sqlalchemy/sql/compiler.py b/lib/sqlalchemy/sql/compiler.py index 29aa57faa..710c62c59 100644 --- a/lib/sqlalchemy/sql/compiler.py +++ b/lib/sqlalchemy/sql/compiler.py @@ -227,6 +227,7 @@ FUNCTIONS = { functions.grouping_sets: "GROUPING SETS", } + EXTRACT_MAP = { "month": "month", "day": "day", @@ -1036,57 +1037,28 @@ class SQLCompiler(Compiled): return pd @util.memoized_instancemethod - def _get_set_input_sizes_lookup( - self, include_types=None, exclude_types=None - ): - if not hasattr(self, "bind_names"): - return None - + def _get_set_input_sizes_lookup(self): dialect = self.dialect - dbapi = self.dialect.dbapi - # _unwrapped_dialect_impl() is necessary so that we get the - # correct dialect type for a custom TypeDecorator, or a Variant, - # which is also a TypeDecorator. Special types like Interval, - # that use TypeDecorator but also might be mapped directly - # for a dialect impl, also subclass Emulated first which overrides - # this behavior in those cases to behave like the default. + include_types = dialect.include_set_input_sizes + exclude_types = dialect.exclude_set_input_sizes - if include_types is None and exclude_types is None: + dbapi = dialect.dbapi - def _lookup_type(typ): - dbtype = typ.dialect_impl(dialect).get_dbapi_type(dbapi) - return dbtype + def lookup_type(typ): + dbtype = typ._unwrapped_dialect_impl(dialect).get_dbapi_type(dbapi) - else: - - def _lookup_type(typ): - # note we get dbtype from the possibly TypeDecorator-wrapped - # dialect_impl, but the dialect_impl itself that we use for - # include/exclude is the unwrapped version. - - dialect_impl = typ._unwrapped_dialect_impl(dialect) - - dbtype = typ.dialect_impl(dialect).get_dbapi_type(dbapi) - - if ( - dbtype is not None - and ( - exclude_types is None - or dbtype not in exclude_types - and type(dialect_impl) not in exclude_types - ) - and ( - include_types is None - or dbtype in include_types - or type(dialect_impl) in include_types - ) - ): - return dbtype - else: - return None + if ( + dbtype is not None + and (exclude_types is None or dbtype not in exclude_types) + and (include_types is None or dbtype in include_types) + ): + return dbtype + else: + return None inputsizes = {} + literal_execute_params = self.literal_execute_params for bindparam in self.bind_names: @@ -1095,10 +1067,10 @@ class SQLCompiler(Compiled): if bindparam.type._is_tuple_type: inputsizes[bindparam] = [ - _lookup_type(typ) for typ in bindparam.type.types + lookup_type(typ) for typ in bindparam.type.types ] else: - inputsizes[bindparam] = _lookup_type(bindparam.type) + inputsizes[bindparam] = lookup_type(bindparam.type) return inputsizes @@ -2061,7 +2033,25 @@ class SQLCompiler(Compiled): parameter, values ) - typ_dialect_impl = parameter.type._unwrapped_dialect_impl(self.dialect) + dialect = self.dialect + typ_dialect_impl = parameter.type._unwrapped_dialect_impl(dialect) + + if ( + self.dialect._bind_typing_render_casts + and typ_dialect_impl.render_bind_cast + ): + + def _render_bindtemplate(name): + return self.render_bind_cast( + parameter.type, + typ_dialect_impl, + self.bindtemplate % {"name": name}, + ) + + else: + + def _render_bindtemplate(name): + return self.bindtemplate % {"name": name} if not values: to_update = [] @@ -2088,14 +2078,16 @@ class SQLCompiler(Compiled): for i, tuple_element in enumerate(values, 1) for j, value in enumerate(tuple_element, 1) ] + replacement_expression = ( - "VALUES " if self.dialect.tuple_in_values else "" + "VALUES " if dialect.tuple_in_values else "" ) + ", ".join( "(%s)" % ( ", ".join( - self.bindtemplate - % {"name": to_update[i * len(tuple_element) + j][0]} + _render_bindtemplate( + to_update[i * len(tuple_element) + j][0] + ) for j, value in enumerate(tuple_element) ) ) @@ -2107,7 +2099,7 @@ class SQLCompiler(Compiled): for i, value in enumerate(values, 1) ] replacement_expression = ", ".join( - self.bindtemplate % {"name": key} for key, value in to_update + _render_bindtemplate(key) for key, value in to_update ) return to_update, replacement_expression @@ -2376,6 +2368,7 @@ class SQLCompiler(Compiled): m = re.match( r"^(.*)\(__\[POSTCOMPILE_(\S+?)\]\)(.*)$", wrapped ) + assert m, "unexpected format for expanding parameter" wrapped = "(__[POSTCOMPILE_%s~~%s~~REPL~~%s~~])" % ( m.group(2), m.group(1), @@ -2463,13 +2456,18 @@ class SQLCompiler(Compiled): name, post_compile=post_compile, expanding=bindparam.expanding, + bindparam_type=bindparam.type, **kwargs ) if bindparam.expanding: ret = "(%s)" % ret + return ret + def render_bind_cast(self, type_, dbapi_type, sqltext): + raise NotImplementedError() + def render_literal_bindparam( self, bindparam, render_literal_value=NO_ARG, **kw ): @@ -2556,6 +2554,7 @@ class SQLCompiler(Compiled): post_compile=False, expanding=False, escaped_from=None, + bindparam_type=None, **kw ): @@ -2583,8 +2582,18 @@ class SQLCompiler(Compiled): self.escaped_bind_names[escaped_from] = name if post_compile: return "__[POSTCOMPILE_%s]" % name - else: - return self.bindtemplate % {"name": name} + + ret = self.bindtemplate % {"name": name} + + if ( + bindparam_type is not None + and self.dialect._bind_typing_render_casts + ): + type_impl = bindparam_type._unwrapped_dialect_impl(self.dialect) + if type_impl.render_bind_cast: + ret = self.render_bind_cast(bindparam_type, type_impl, ret) + + return ret def visit_cte( self, |