diff options
| author | Federico Caselli <cfederico87@gmail.com> | 2021-04-21 22:49:09 +0200 |
|---|---|---|
| committer | Mike Bayer <mike_mp@zzzcomputing.com> | 2021-04-28 20:03:27 -0400 |
| commit | d3c73ad8012e15bf47529b3fcb0bac1298fbdb90 (patch) | |
| tree | 31ae2c420b9d58d55e56a9191a34176c1deb7c16 /lib/sqlalchemy/sql/compiler.py | |
| parent | 1443945e61f1f113e46a5044315a91558d4d232a (diff) | |
| download | sqlalchemy-d3c73ad8012e15bf47529b3fcb0bac1298fbdb90.tar.gz | |
Propertly ignore ``Identity`` in MySQL and MariaDb.
Ensure that the MySQL and MariaDB dialect ignore the
:class:`_sql.Identity` construct while rendering the
``AUTO_INCREMENT`` keyword in a create table.
The Oracle and PostgreSQL compiler was updated to not render
:class:`_sql.Identity` if the database version does not support it
(Oracle < 12 and PostgreSQL < 10). Previously it was rendered regardless
of the database version.
Fixes: #6338
Change-Id: I2ca0902fdd7b4be4fc1a563cf5585504cbea9360
Diffstat (limited to 'lib/sqlalchemy/sql/compiler.py')
| -rw-r--r-- | lib/sqlalchemy/sql/compiler.py | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/lib/sqlalchemy/sql/compiler.py b/lib/sqlalchemy/sql/compiler.py index 6168248ff..bd93f5199 100644 --- a/lib/sqlalchemy/sql/compiler.py +++ b/lib/sqlalchemy/sql/compiler.py @@ -4257,10 +4257,15 @@ class DDLCompiler(Compiled): if column.computed is not None: colspec += " " + self.process(column.computed) - if column.identity is not None: + if ( + column.identity is not None + and self.dialect.supports_identity_columns + ): colspec += " " + self.process(column.identity) - if not column.nullable and not column.identity: + if not column.nullable and ( + not column.identity or not self.dialect.supports_identity_columns + ): colspec += " NOT NULL" return colspec |