summaryrefslogtreecommitdiff
path: root/lib/sqlalchemy/sql/dml.py
diff options
context:
space:
mode:
authorMike Bayer <mike_mp@zzzcomputing.com>2020-08-12 20:14:15 -0400
committerMike Bayer <mike_mp@zzzcomputing.com>2020-08-12 22:00:43 -0400
commit65da69910944ccbad0c6d008b94ae8271aae4762 (patch)
treefa20af57e5c928672124865859b57a7fe9a094d4 /lib/sqlalchemy/sql/dml.py
parentc7cf63d64e2b47cdabcda622af86513ec192f4a4 (diff)
downloadsqlalchemy-65da69910944ccbad0c6d008b94ae8271aae4762.tar.gz
Sweep through UPDATE ordered_values a second time
The fix in 180ae7c1a53385f72b0047496ac001ec5099cc3e didn't do much as the code was not preserving parameter order at all, in fact. Reworked stmt_parameters to be delivered in the correct order up front and preserve throughout crud.py which was not being done at all before. Fixes: #5510 Change-Id: I0795c71df73005a25d1bbf216732d41b41e11a5f
Diffstat (limited to 'lib/sqlalchemy/sql/dml.py')
-rw-r--r--lib/sqlalchemy/sql/dml.py2
1 files changed, 2 insertions, 0 deletions
diff --git a/lib/sqlalchemy/sql/dml.py b/lib/sqlalchemy/sql/dml.py
index 930865898..a9bccaeff 100644
--- a/lib/sqlalchemy/sql/dml.py
+++ b/lib/sqlalchemy/sql/dml.py
@@ -34,6 +34,7 @@ class DMLState(CompileState):
_no_parameters = True
_dict_parameters = None
_multi_parameters = None
+ _ordered_values = None
_parameter_ordering = None
_has_multi_parameters = False
isupdate = False
@@ -97,6 +98,7 @@ class DMLState(CompileState):
if self._no_parameters:
self._no_parameters = False
self._dict_parameters = dict(parameters)
+ self._ordered_values = parameters
self._parameter_ordering = [key for key, value in parameters]
elif self._has_multi_parameters:
self._cant_mix_formats_error()