summaryrefslogtreecommitdiff
path: root/lib/sqlalchemy/sql/schema.py
diff options
context:
space:
mode:
authorMike Bayer <mike_mp@zzzcomputing.com>2020-05-22 00:06:06 -0400
committerMike Bayer <mike_mp@zzzcomputing.com>2020-05-23 00:05:13 -0400
commitfcbd03e48af50e301e0dcbade75765a4d3e4999f (patch)
tree8a30c4b9811bb217430c6bafea040753729c80ae /lib/sqlalchemy/sql/schema.py
parentd45657a2f5b880dc22dda2d1eb1687af5234a470 (diff)
downloadsqlalchemy-fcbd03e48af50e301e0dcbade75765a4d3e4999f.tar.gz
Add immutabledict C code
Start trying to convert fundamental objects to C as we now rely on a fairly small core of things, and 1.4 is having problems with complexity added being slower than the performance gains we are trying to build in. immutabledict here does seem to bench as twice as fast as the Python one, see below. However, it does not appear to be used prominently enough to make any dent in the performance tests. at the very least it may provide us some more lift-and-copy code for more C extensions. import timeit from sqlalchemy.util._collections import not_immutabledict, immutabledict def run(dict_cls): for i in range(1000000): d1 = dict_cls({"x": 5, "y": 4}) d2 = d1.union({"x": 17, "new key": "some other value"}, None) assert list(d2) == ["x", "y", "new key"] print( timeit.timeit( "run(d)", "from __main__ import run, not_immutabledict as d", number=1 ) ) print( timeit.timeit( "run(d)", "from __main__ import run, immutabledict as d", number=1 ) ) output: python: 1.8799766399897635 C code: 0.8880784640205093 Change-Id: I29e7104dc21dcc7cdf895bf274003af2e219bf6d
Diffstat (limited to 'lib/sqlalchemy/sql/schema.py')
-rw-r--r--lib/sqlalchemy/sql/schema.py4
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/sqlalchemy/sql/schema.py b/lib/sqlalchemy/sql/schema.py
index fd1e3fa38..689eda11d 100644
--- a/lib/sqlalchemy/sql/schema.py
+++ b/lib/sqlalchemy/sql/schema.py
@@ -3972,7 +3972,7 @@ class MetaData(SchemaItem):
examples.
"""
- self.tables = util.immutabledict()
+ self.tables = util.FacadeDict()
self.schema = quoted_name(schema, quote_schema)
self.naming_convention = (
naming_convention
@@ -4015,7 +4015,7 @@ class MetaData(SchemaItem):
def _add_table(self, name, schema, table):
key = _get_table_key(name, schema)
- dict.__setitem__(self.tables, key, table)
+ self.tables._insert_item(key, table)
if schema:
self._schemas.add(schema)