diff options
| author | Mike Bayer <mike_mp@zzzcomputing.com> | 2019-12-27 15:02:31 -0500 |
|---|---|---|
| committer | Mike Bayer <mike_mp@zzzcomputing.com> | 2019-12-30 14:07:18 -0500 |
| commit | 04fbb9e63c098dd2de40b545eed210dfd93893ce (patch) | |
| tree | f509e09f71c9a382b2d7934cf81262ad019df377 /lib/sqlalchemy/sql/visitors.py | |
| parent | 9d4a58d35c53484a1de66396139fc34cd65f5be8 (diff) | |
| download | sqlalchemy-04fbb9e63c098dd2de40b545eed210dfd93893ce.tar.gz | |
Test for short term reference cycles and resolve as many as possible
Added test support and repaired a wide variety of unnecessary reference
cycles created for short-lived objects, mostly in the area of ORM queries.
Fixes: #5056
Change-Id: Ifd93856eba550483f95f9ae63d49f36ab068b85a
Diffstat (limited to 'lib/sqlalchemy/sql/visitors.py')
| -rw-r--r-- | lib/sqlalchemy/sql/visitors.py | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/lib/sqlalchemy/sql/visitors.py b/lib/sqlalchemy/sql/visitors.py index dcded3484..afa1506d2 100644 --- a/lib/sqlalchemy/sql/visitors.py +++ b/lib/sqlalchemy/sql/visitors.py @@ -722,7 +722,7 @@ def cloned_traverse(obj, opts, visitors): return newelem cloned[id(elem)] = newelem = elem._clone() - newelem._copy_internals(clone=clone) + newelem._copy_internals(clone=clone, **kw) meth = visitors.get(newelem.__visit_name__, None) if meth: meth(newelem) @@ -730,6 +730,7 @@ def cloned_traverse(obj, opts, visitors): if obj is not None: obj = clone(obj) + clone = None # remove gc cycles return obj @@ -786,4 +787,5 @@ def replacement_traverse(obj, opts, replace): if obj is not None: obj = clone(obj, **opts) + clone = None # remove gc cycles return obj |