diff options
| author | Mike Bayer <mike_mp@zzzcomputing.com> | 2021-06-02 23:07:28 -0400 |
|---|---|---|
| committer | Mike Bayer <mike_mp@zzzcomputing.com> | 2021-06-02 23:07:28 -0400 |
| commit | dcdc9442ed94f0857a62de40e17e588250f0576e (patch) | |
| tree | c05d872d6d16f066bd04ba27aeeec6b9d1887d16 /lib/sqlalchemy/testing/assertions.py | |
| parent | cf8c76b9fcfcd1e79da4b089e7a86d6300d737e1 (diff) | |
| download | sqlalchemy-dcdc9442ed94f0857a62de40e17e588250f0576e.tar.gz | |
delete exception traceback in _expect_raises
a new segfault is observed in python 3.10.0b2 in conjunction
with asyncio and possibly greenlet. Ensuring the
traceback object is deleted from scope here, which is a
good idea anyway, apparently seems to resolve the issue.
Change-Id: Ia83bafb088ef19853044f1d436db259cbfd1e5f4
References: https://github.com/python-greenlet/greenlet/issues/242
Diffstat (limited to 'lib/sqlalchemy/testing/assertions.py')
| -rw-r--r-- | lib/sqlalchemy/testing/assertions.py | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/lib/sqlalchemy/testing/assertions.py b/lib/sqlalchemy/testing/assertions.py index 9ff2f76eb..b618021a6 100644 --- a/lib/sqlalchemy/testing/assertions.py +++ b/lib/sqlalchemy/testing/assertions.py @@ -372,6 +372,13 @@ def _expect_raises(except_cls, msg=None, check_context=False): _assert_proper_exception_context(err) print(util.text_type(err).encode("utf-8")) + # it's generally a good idea to not carry traceback objects outside + # of the except: block, but in this case especially we seem to have + # hit some bug in either python 3.10.0b2 or greenlet or both which + # this seems to fix: + # https://github.com/python-greenlet/greenlet/issues/242 + del ec + # assert outside the block so it works for AssertionError too ! assert success, "Callable did not raise an exception" |