summaryrefslogtreecommitdiff
path: root/test/dialect/oracle/test_reflection.py
diff options
context:
space:
mode:
authorGord Thompson <gord@gordthompson.com>2020-03-09 17:50:53 -0400
committerMike Bayer <mike_mp@zzzcomputing.com>2020-03-10 10:40:41 -0400
commit0c294d356f7cbb22a8da3fc4552a9c4232c3f69a (patch)
tree416da7855b506c96b9e64018b6b2dab20255b6be /test/dialect/oracle/test_reflection.py
parentb2c4a84643d190c05649a56e5bc75a4b381a4017 (diff)
downloadsqlalchemy-0c294d356f7cbb22a8da3fc4552a9c4232c3f69a.tar.gz
Reflect comments from any table accessible by the current user
Fixed a reflection bug where table comments could only be retrieved for tables actually owned by the user but not for tables visible to the user but owned by someone else. Pull request courtesy Dave Hirschfeld. Fixes: #5146 Closes: #5147 Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/5147 Pull-request-sha: 0651e3bed05923765203b37986a2506dac3e634e Change-Id: If970fda10d6adf04d926d38df1a567df1de9f7b9
Diffstat (limited to 'test/dialect/oracle/test_reflection.py')
-rw-r--r--test/dialect/oracle/test_reflection.py5
1 files changed, 5 insertions, 0 deletions
diff --git a/test/dialect/oracle/test_reflection.py b/test/dialect/oracle/test_reflection.py
index 6c36c0a6b..411ba335c 100644
--- a/test/dialect/oracle/test_reflection.py
+++ b/test/dialect/oracle/test_reflection.py
@@ -49,6 +49,8 @@ create table %(test_schema)s.parent(
data varchar2(50)
);
+COMMENT ON TABLE %(test_schema)s.parent IS 'my table comment';
+
create table %(test_schema)s.child(
id integer primary key,
data varchar2(50),
@@ -189,6 +191,9 @@ drop synonym %(test_schema)s.local_table;
parent.join(child)
).execute().fetchall()
+ # check table comment (#5146)
+ eq_(parent.comment, "my table comment")
+
def test_reflect_local_to_remote(self):
testing.db.execute(
"CREATE TABLE localtable (id INTEGER "