diff options
author | Federico Caselli <cfederico87@gmail.com> | 2021-06-03 22:38:15 +0200 |
---|---|---|
committer | Federico Caselli <cfederico87@gmail.com> | 2021-06-08 22:02:42 +0200 |
commit | d200ba26a0f5b8542ec258d2fcfe0b53a80af42c (patch) | |
tree | 38c6a9f72da15d6c496f1e24f621c3a78ee3e863 /test/ext/asyncio/test_engine_py3k.py | |
parent | dd5d6d15467b66398dd328ff43b863a057899291 (diff) | |
download | sqlalchemy-d200ba26a0f5b8542ec258d2fcfe0b53a80af42c.tar.gz |
Propagate asyncio flag from the dialect to selected pool classes
Fixed an issue that presented itself when using the :class:`_pool.NullPool`
or the :class:`_pool.StaticPool` with an async engine. This mostly affected
the aiosqlite dialect.
Fixes: #6575
Change-Id: Ic1e27d99ffcb20ed4de82ea78f430a0f3b629d86
Diffstat (limited to 'test/ext/asyncio/test_engine_py3k.py')
-rw-r--r-- | test/ext/asyncio/test_engine_py3k.py | 15 |
1 files changed, 6 insertions, 9 deletions
diff --git a/test/ext/asyncio/test_engine_py3k.py b/test/ext/asyncio/test_engine_py3k.py index d47ef5f3f..fec8bc6da 100644 --- a/test/ext/asyncio/test_engine_py3k.py +++ b/test/ext/asyncio/test_engine_py3k.py @@ -230,14 +230,8 @@ class AsyncEngineTest(EngineFixture): is_false(async_engine == None) - # NOTE: this test currently causes the test suite to hang; it previously - # was not actually running the worker thread - # as the testing_engine() fixture - # was rejecting the "transfer_staticpool" keyword argument @async_test - async def temporarily_dont_test_no_attach_to_event_loop( - self, testing_engine - ): + async def test_no_attach_to_event_loop(self, testing_engine): """test #6409""" import asyncio @@ -249,12 +243,11 @@ class AsyncEngineTest(EngineFixture): loop = asyncio.new_event_loop() asyncio.set_event_loop(loop) - engine = testing_engine(asyncio=True, transfer_staticpool=True) - async def main(): tasks = [task() for _ in range(2)] await asyncio.gather(*tasks) + await engine.dispose() async def task(): async with engine.begin() as connection: @@ -262,6 +255,10 @@ class AsyncEngineTest(EngineFixture): result.all() try: + engine = testing_engine( + asyncio=True, transfer_staticpool=False + ) + asyncio.run(main()) except Exception as err: errs.append(err) |