summaryrefslogtreecommitdiff
path: root/test/ext/mypy/plain_files/sessionmakers.py
diff options
context:
space:
mode:
authorSam Bull <aa6bs0@sambull.org>2022-11-19 19:38:04 -0500
committerMike Bayer <mike_mp@zzzcomputing.com>2022-11-21 12:01:56 -0500
commite43e240a0088ac429eb551c7ea1c537c266b4853 (patch)
tree7a5604931823414fc133cf04b04e4f6607904b7c /test/ext/mypy/plain_files/sessionmakers.py
parent46e6693cb3db445f18aa25d5e4ca613504bd12b3 (diff)
downloadsqlalchemy-e43e240a0088ac429eb551c7ea1c537c266b4853.tar.gz
Fix inferred type of async_sessionmaker
Improved the typing for :class:`.sessionmaker` and :class:`.asyncsessionmaker`, so that the default type of their return value will be :class:`.Session` or :class:`.AsyncSession`, without the need to type this explicitly. Previously, Mypy would not automaticaly infer these return types from its generic base. As part of this change, arguments for :class:`.Session`, :class:`.AsyncSession`, :class:`.sessionmaker` and :class:`.asyncsessionmaker` beyond the initial "bind" argument have been made keyword-only, which includes parameters that have always been documented as keyword arguments, such as :paramref:`.Session.autoflush`, :paramref:`.Session.class_`, etc. Pull request courtesy Sam Bull. Closes: #8842 Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/8842 Pull-request-sha: fa6d1a8468e98b40e12f82ed7ddaddc1fde060ac Change-Id: Iaaabc4572a87489d61617d970f62b9b50db4fac7
Diffstat (limited to 'test/ext/mypy/plain_files/sessionmakers.py')
-rw-r--r--test/ext/mypy/plain_files/sessionmakers.py24
1 files changed, 24 insertions, 0 deletions
diff --git a/test/ext/mypy/plain_files/sessionmakers.py b/test/ext/mypy/plain_files/sessionmakers.py
index ce9b76638..2d02f2a3f 100644
--- a/test/ext/mypy/plain_files/sessionmakers.py
+++ b/test/ext/mypy/plain_files/sessionmakers.py
@@ -86,3 +86,27 @@ def main() -> None:
sess = scoped_fac()
# EXPECTED_TYPE: MySession
reveal_type(sess)
+
+
+def test_8837_sync() -> None:
+ sm = sessionmaker()
+
+ # EXPECTED_TYPE: sessionmaker[Session]
+ reveal_type(sm)
+
+ session = sm()
+
+ # EXPECTED_TYPE: Session
+ reveal_type(session)
+
+
+def test_8837_async() -> None:
+ as_ = async_sessionmaker()
+
+ # EXPECTED_TYPE: async_sessionmaker[AsyncSession]
+ reveal_type(as_)
+
+ async_session = as_()
+
+ # EXPECTED_TYPE: AsyncSession
+ reveal_type(async_session)