diff options
| author | Anderson Bravalheri <andersonbravalheri+github@gmail.com> | 2022-06-13 09:04:51 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-06-13 09:04:51 +0100 |
| commit | 1e8cf37631e5c19b941011cff33f3b3e9b1e8029 (patch) | |
| tree | a17782819c5e78bf50bb55b1607ce87374113b46 | |
| parent | 4e9780ff399636a541b0e39b89110f684b7ac2b9 (diff) | |
| download | python-setuptools-git-1e8cf37631e5c19b941011cff33f3b3e9b1e8029.tar.gz | |
Apply suggestions from code review
| -rw-r--r-- | docs/deprecated/resource_extraction.rst | 2 | ||||
| -rw-r--r-- | docs/deprecated/zip_safe.rst | 2 | ||||
| -rw-r--r-- | docs/userguide/extension.rst | 4 |
3 files changed, 4 insertions, 4 deletions
diff --git a/docs/deprecated/resource_extraction.rst b/docs/deprecated/resource_extraction.rst index 19190baf..c481e339 100644 --- a/docs/deprecated/resource_extraction.rst +++ b/docs/deprecated/resource_extraction.rst @@ -8,7 +8,7 @@ and all the files can be found on deterministic locations on the disk. This means that most of the tools expect package resources to be "real" files. There are a few occasions however that packages are loaded in a different way -(e.g. from a zip file), which is incompatible with the assumptions mentioned above. +(e.g., from a zip file), which is incompatible with the assumptions mentioned above. Moreover, a package developer may also include non-extension native libraries or other files that C extensions may expect to be able to access. diff --git a/docs/deprecated/zip_safe.rst b/docs/deprecated/zip_safe.rst index 1b299b3c..08a13334 100644 --- a/docs/deprecated/zip_safe.rst +++ b/docs/deprecated/zip_safe.rst @@ -24,7 +24,7 @@ Not all packages, however, are capable of running in compressed form, because they may expect to be able to access either source code or data files as normal operating system files. -In the past, ``setuptools`` would install an project distributed +In the past, ``setuptools`` would install a project distributed as a zipfile or a directory (via the ``easy_install`` command or ``python setup.py install``), the default choice being determined by the project's ``zip_safe`` flag. diff --git a/docs/userguide/extension.rst b/docs/userguide/extension.rst index 4ecfc3ee..fb620c50 100644 --- a/docs/userguide/extension.rst +++ b/docs/userguide/extension.rst @@ -55,9 +55,9 @@ Once a project containing such entry points has been activated on ``sys.path``, how setuptools' own commands are installed: the setuptools project's setup script defines entry points for them! -The commands ``sdist``, ``build_py`` and ``build_ext`` are specially useful +The commands ``sdist``, ``build_py`` and ``build_ext`` are especially useful to customize ``setuptools`` builds. Note however that when overwriting existing -commands you should be very careful to maintain API compatibility. +commands, you should be very careful to maintain API compatibility. Custom commands should try to replicate the same overall behaviour as the original classes, and when possible, even inherit from them. |