summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Brown <mcb30@ipxe.org>2023-01-25 00:02:11 +0000
committerMichael Brown <mcb30@ipxe.org>2023-01-25 00:02:11 +0000
commit7adef776fd4c89804a99eabda990ca59f1bdb001 (patch)
treec820fc86f0f0e19d42e86151fd33159a7e3f9294
parentc5426cdaa943a14183edb424b472d7e0d7e55cc3 (diff)
downloadqemu-ipxe-tcpwindow.tar.gz
[tcp] Update maximum window size to 2MBtcpwindow
The current maximum window size of 256kB was calculated based on rough link bandwidth and RTT measurements taken in 2012, and is too small to avoid filling the TCP window on some modern links. Update the list of typical link bandwidth and RTT figures to reflect the modern world, and increase the maximum window size accordingly. Signed-off-by: Michael Brown <mcb30@ipxe.org>
-rw-r--r--src/include/ipxe/tcp.h18
1 files changed, 12 insertions, 6 deletions
diff --git a/src/include/ipxe/tcp.h b/src/include/ipxe/tcp.h
index f5508fe2..1f65a3d9 100644
--- a/src/include/ipxe/tcp.h
+++ b/src/include/ipxe/tcp.h
@@ -339,11 +339,17 @@ struct tcp_options {
* a) Gigabit LAN: expected bandwidth 125MB/s, typical RTT 0.5ms,
* minimum required window 64kB
*
- * b) Home Internet connection: expected bandwidth 10MB/s, typical
- * RTT 25ms, minimum required window 256kB
+ * b) 10-Gigabit LAN: expected bandwidth 1250MB/s, typical RTT
+ * 0.5ms, minimum required window 640kB
*
- * c) WAN: expected bandwidth 2MB/s, typical RTT 100ms, minimum
- * required window 200kB.
+ * c) Home Internet connection: expected bandwidth 50MB/s, typical
+ * RTT 25ms, minimum required window 1280kB
+ *
+ * d) International WAN: expected bandwidth 50MB/s, typical RTT
+ * 25ms, minimum required window 1280kB
+ *
+ * e) Intercontinental WAN: expected bandwidth 5MB/s, typical RTT
+ * 250ms, minimum required window 1280kB.
*
* The maximum possible value for the TCP window size is 1GB (using
* the maximum window scale of 2**14). However, it is advisable to
@@ -351,9 +357,9 @@ struct tcp_options {
* bandwidth), since in the event of a lost packet the window size
* represents the maximum amount that will need to be retransmitted.
*
- * We therefore choose a maximum window size of 256kB.
+ * We therefore choose a (rounded up) maximum window size of 2048kB.
*/
-#define TCP_MAX_WINDOW_SIZE ( 256 * 1024 )
+#define TCP_MAX_WINDOW_SIZE ( 2048 * 1024 )
/**
* Path MTU