summaryrefslogtreecommitdiff
path: root/src/libs/qmljs/qmljscheck.cpp
diff options
context:
space:
mode:
authorChristian Kamm <christian.d.kamm@nokia.com>2011-09-30 09:50:08 +0200
committerChristian Kamm <christian.d.kamm@nokia.com>2011-10-10 14:39:39 +0200
commitda123becafb8cfb3a3a453049563bae29b135147 (patch)
tree8ff06ca7a9a9f7ccaa48a07b9e26d721925f3521 /src/libs/qmljs/qmljscheck.cpp
parent55713a1514adab455ba99d27bd0d2656d221947a (diff)
downloadqt-creator-da123becafb8cfb3a3a453049563bae29b135147.tar.gz
QmlJS checks: Add Hint about anonymous function formatting.
Migrated from QtChecker. Change-Id: I0178cc189d1c98b51e1aeb43db7421ba8c43fc7e Reviewed-on: http://codereview.qt-project.org/5856 Reviewed-by: Fawzi Mohamed <fawzi.mohamed@nokia.com> Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Diffstat (limited to 'src/libs/qmljs/qmljscheck.cpp')
-rw-r--r--src/libs/qmljs/qmljscheck.cpp10
1 files changed, 10 insertions, 0 deletions
diff --git a/src/libs/qmljs/qmljscheck.cpp b/src/libs/qmljs/qmljscheck.cpp
index 20d9e40efc..cdf88e0c01 100644
--- a/src/libs/qmljs/qmljscheck.cpp
+++ b/src/libs/qmljs/qmljscheck.cpp
@@ -807,6 +807,16 @@ bool Check::visit(FunctionDeclaration *ast)
bool Check::visit(FunctionExpression *ast)
{
+ if (ast->name.isEmpty()) {
+ SourceLocation locfunc = ast->functionToken;
+ SourceLocation loclparen = ast->lparenToken;
+ if (locfunc.isValid() && loclparen.isValid()
+ && (locfunc.startLine != loclparen.startLine
+ || locfunc.end() + 1 != loclparen.begin())) {
+ addMessage(HintAnonymousFunctionSpacing, locationFromRange(locfunc, loclparen));
+ }
+ }
+
DeclarationsCheck bodyCheck;
addMessages(bodyCheck(ast));