summaryrefslogtreecommitdiff
path: root/src/libs/qmljs/qmljscheck.cpp
diff options
context:
space:
mode:
authorEike Ziller <eike.ziller@qt.io>2022-04-22 10:04:39 +0200
committerEike Ziller <eike.ziller@qt.io>2022-04-22 10:04:39 +0200
commite2d5b6616aa4f7c0f875295ebe7951b097e4a052 (patch)
tree0ab417e0f24a080dc5d1471e1916832e865070ff /src/libs/qmljs/qmljscheck.cpp
parentfd02996ec97556afd4041c68cbf3afadc076efbf (diff)
parent9656eb9e7a13213c51a9674a50f710b02abbe124 (diff)
downloadqt-creator-e2d5b6616aa4f7c0f875295ebe7951b097e4a052.tar.gz
Merge remote-tracking branch 'origin/7.0'
Change-Id: I01ce83a2da66bb65af37c0ecc92372789cb85c01
Diffstat (limited to 'src/libs/qmljs/qmljscheck.cpp')
-rw-r--r--src/libs/qmljs/qmljscheck.cpp14
1 files changed, 13 insertions, 1 deletions
diff --git a/src/libs/qmljs/qmljscheck.cpp b/src/libs/qmljs/qmljscheck.cpp
index c5a186bda8..aae32a6dd9 100644
--- a/src/libs/qmljs/qmljscheck.cpp
+++ b/src/libs/qmljs/qmljscheck.cpp
@@ -1350,7 +1350,17 @@ static bool isStringValue(const Value *value)
if (value->asStringValue())
return true;
if (auto obj = value->asObjectValue())
- return obj->className() == "QString" || obj->className() == "string";
+ return obj->className() == "QString" || obj->className() == "string" || obj->className() == "String";
+
+ return false;
+}
+
+static bool isBooleanValue(const Value *value)
+{
+ if (value->asBooleanValue())
+ return true;
+ if (auto obj = value->asObjectValue())
+ return obj->className() == "boolean" || obj->className() == "Boolean";
return false;
}
@@ -1368,6 +1378,8 @@ static bool strictCompareConstant(const Value *lhs, const Value *rhs)
return false;
if (isStringValue(lhs) && isStringValue(rhs))
return false;
+ if (isBooleanValue(lhs) && isBooleanValue(rhs))
+ return false;
if (lhs->asBooleanValue() && !rhs->asBooleanValue())
return true;
if (lhs->asNumberValue() && !rhs->asNumberValue())