diff options
| author | Jarek Kobus <jaroslaw.kobus@qt.io> | 2020-11-17 09:09:05 +0100 |
|---|---|---|
| committer | Jarek Kobus <jaroslaw.kobus@qt.io> | 2020-11-17 11:30:23 +0000 |
| commit | 3998e30684bb8f7e81c7f51be38aa77fd351ff3d (patch) | |
| tree | 3f0943be490d42564798fcdbdc8246048d36505d /src/plugins/autotest/quick/quicktestparser.cpp | |
| parent | a05a0a61d0760fb35730737618989c513dc7926d (diff) | |
| download | qt-creator-3998e30684bb8f7e81c7f51be38aa77fd351ff3d.tar.gz | |
Fix a warning about const signal
Fix a [clazy-const-signal-or-slot] warning. Instead of defining
a signal for internal usage, use directly QMetaObject::invokeMethod().
Don't declare scanDirectoryForQuickTestQmlFiles() a const method
anymore.
Change-Id: I036afc6124dfb877ced7d9e798920c8a8fde1892
Reviewed-by: hjk <hjk@qt.io>
Diffstat (limited to 'src/plugins/autotest/quick/quicktestparser.cpp')
| -rw-r--r-- | src/plugins/autotest/quick/quicktestparser.cpp | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/src/plugins/autotest/quick/quicktestparser.cpp b/src/plugins/autotest/quick/quicktestparser.cpp index 1c481a2857..06fbb53ad3 100644 --- a/src/plugins/autotest/quick/quicktestparser.cpp +++ b/src/plugins/autotest/quick/quicktestparser.cpp @@ -139,7 +139,7 @@ static QString quickTestName(const CPlusPlus::Document::Ptr &doc, return astVisitor.testBaseName(); } -QList<Document::Ptr> QuickTestParser::scanDirectoryForQuickTestQmlFiles(const QString &srcDir) const +QList<Document::Ptr> QuickTestParser::scanDirectoryForQuickTestQmlFiles(const QString &srcDir) { QStringList dirs(srcDir); ModelManagerInterface *qmlJsMM = QmlJSTools::Internal::ModelManager::instance(); @@ -157,7 +157,8 @@ QList<Document::Ptr> QuickTestParser::scanDirectoryForQuickTestQmlFiles(const QS QFileInfo fi(it.fileInfo().canonicalFilePath()); dirs.append(fi.filePath()); } - emit updateWatchPaths(dirs); + QMetaObject::invokeMethod(this, [this, dirs] { QuickTestParser::doUpdateWatchPaths(dirs); }, + Qt::QueuedConnection); QList<Document::Ptr> foundDocs; @@ -310,8 +311,6 @@ QuickTestParser::QuickTestParser(ITestFramework *framework) }); connect(&m_directoryWatcher, &QFileSystemWatcher::directoryChanged, this, &QuickTestParser::handleDirectoryChanged); - connect(this, &QuickTestParser::updateWatchPaths, - this, &QuickTestParser::doUpdateWatchPaths, Qt::QueuedConnection); } void QuickTestParser::init(const QStringList &filesToParse, bool fullParse) |