diff options
| author | Orgad Shaneh <orgad.shaneh@audiocodes.com> | 2022-10-22 22:16:44 +0300 |
|---|---|---|
| committer | Orgad Shaneh <orgads@gmail.com> | 2022-10-25 19:19:40 +0000 |
| commit | d63bfa4a2975541b51fc8173fdb06933bb9dd40d (patch) | |
| tree | 147d436e0b06e6a347058e0edfd70bb867b8da49 /src/plugins/bazaar/bazaarplugin.cpp | |
| parent | aa339276515da0b8c40193813de00d3cebfa1a3b (diff) | |
| download | qt-creator-d63bfa4a2975541b51fc8173fdb06933bb9dd40d.tar.gz | |
VCS: Simplify submit editor accept/close flow
* Replace message box with an error on the output pane.
* Separate logic for accept and close.
Change-Id: Ib9fa201a1a67ee195086f7a22bc6678a9642452a
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Diffstat (limited to 'src/plugins/bazaar/bazaarplugin.cpp')
| -rw-r--r-- | src/plugins/bazaar/bazaarplugin.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/plugins/bazaar/bazaarplugin.cpp b/src/plugins/bazaar/bazaarplugin.cpp index 4f417ddc5e..33d13c631f 100644 --- a/src/plugins/bazaar/bazaarplugin.cpp +++ b/src/plugins/bazaar/bazaarplugin.cpp @@ -184,7 +184,7 @@ public: // String -> repository, StringList -> files void changed(const QVariant &); void updateActions(VcsBase::VcsBasePluginPrivate::ActionState) final; - bool submitEditorAboutToClose() final; + bool activateCommit() final; // File menu action slots void addCurrentFile(); @@ -784,7 +784,7 @@ void BazaarPluginPrivate::uncommit() m_client.synchronousUncommit(state.topLevel(), dialog.revision(), dialog.extraOptions()); } -bool BazaarPluginPrivate::submitEditorAboutToClose() +bool BazaarPluginPrivate::activateCommit() { auto commitEditor = qobject_cast<CommitEditor *>(submitEditor()); QTC_ASSERT(commitEditor, return true); |