Cppcheck: Add ability to manually run cppcheck

Run cppcheck on selected files from current project via "Analyze"->"Cppcheck...."
Show results in a separate view in the same manner as ClangTools plugin.

Fixes: QTCREATORBUG-21673
Change-Id: Ibcaf4057a387a990f1da59025f15ba58f996953f
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>

1 files changed, 118 insertions, 0 deletions

diff --git a/src/plugins/cppcheck/cppcheckdiagnosticview.cpp b/src/plugins/cppcheck/cppcheckdiagnosticview.cpp
new file mode 100644
index 0000000000..1f881e5330
--- /dev/null
+++ b/src/plugins/cppcheck/cppcheckdiagnosticview.cpp
@@ -0,0 +1,118 @@
+/****************************************************************************
+**
+** Copyright (C) 2019 Sergey Morozov
+** Contact: https://www.qt.io/licensing/
+**
+** This file is part of Qt Creator.
+**
+** Commercial License Usage
+** Licensees holding valid commercial Qt licenses may use this file in
+** accordance with the commercial license agreement provided with the
+** Software or, alternatively, in accordance with the terms contained in
+** a written agreement between you and The Qt Company. For licensing terms
+** and conditions see https://www.qt.io/terms-conditions. For further
+** information use the contact form at https://www.qt.io/contact-us.
+**
+** GNU General Public License Usage
+** Alternatively, this file may be used under the terms of the GNU
+** General Public License version 3 as published by the Free Software
+** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT
+** included in the packaging of this file. Please review the following
+** information to ensure the GNU General Public License requirements will
+** be met: https://www.gnu.org/licenses/gpl-3.0.html.
+**
+****************************************************************************/
+
+#include "cppcheckdiagnosticview.h"
+
+#include <coreplugin/editormanager/editormanager.h>
+
+#include <debugger/analyzer/diagnosticlocation.h>
+
+namespace Cppcheck {
+namespace Internal {
+
+using namespace Debugger;
+
+DiagnosticView::DiagnosticView(QWidget *parent)
+    : DetailedErrorView(parent)
+{
+    setFrameStyle(QFrame::NoFrame);
+    setAttribute(Qt::WA_MacShowFocusRect, false);
+    setVerticalScrollMode(QAbstractItemView::ScrollPerPixel);
+    setAutoScroll(false);
+    sortByColumn(DiagnosticColumn, Qt::AscendingOrder);
+    setObjectName("CppcheckIssuesView");
+    setWindowTitle(tr("Cppcheck Diagnostics"));
+    setHeaderHidden(true);
+}
+
+void DiagnosticView::goNext()
+{
+    const auto totalFiles = model()->rowCount();
+    if (totalFiles == 0)
+        return;
+
+    const QModelIndex currentIndex = selectionModel()->currentIndex();
+    const QModelIndex parent = currentIndex.parent();
+    const auto onDiagnostic = parent.isValid();
+    if (onDiagnostic && currentIndex.row() < model()->rowCount(parent) - 1) {
+        selectIndex(currentIndex.sibling(currentIndex.row() + 1, 0));
+        return;
+    }
+    auto newFileRow = 0;
+    if (!currentIndex.isValid()) // not selected
+        newFileRow = 0;
+    else if (!onDiagnostic) // selected file
+        newFileRow = currentIndex.row();
+    else // selected last item in file
+        newFileRow = parent.row() == totalFiles - 1 ? 0 : parent.row() + 1;
+    const QModelIndex newParent = model()->index(newFileRow, 0);
+    selectIndex(model()->index(0, 0, newParent));
+}
+
+void DiagnosticView::goBack()
+{
+    const auto totalFiles = model()->rowCount();
+    if (totalFiles == 0)
+        return;
+
+    const QModelIndex currentIndex = selectionModel()->currentIndex();
+    const QModelIndex parent = currentIndex.parent();
+    const auto onDiagnostic = parent.isValid();
+    if (onDiagnostic && currentIndex.row() > 0) {
+        selectIndex(currentIndex.sibling(currentIndex.row() - 1, 0));
+        return;
+    }
+    auto newFileRow = 0;
+    if (!currentIndex.isValid()) // not selected
+        newFileRow = totalFiles - 1;
+    else if (!onDiagnostic) // selected file
+        newFileRow = currentIndex.row() == 0 ? totalFiles - 1 : currentIndex.row() - 1;
+    else // selected first item in file
+        newFileRow = parent.row() == 0 ? totalFiles - 1 : parent.row() - 1;
+    const QModelIndex newParent = model()->index(newFileRow, 0);
+    const auto newParentRows = model()->rowCount(newParent);
+    selectIndex(model()->index(newParentRows - 1, 0, newParent));
+}
+
+DiagnosticView::~DiagnosticView() = default;
+
+void DiagnosticView::openEditorForCurrentIndex()
+{
+    const QVariant v = model()->data(currentIndex(), Debugger::DetailedErrorView::LocationRole);
+    const auto loc = v.value<Debugger::DiagnosticLocation>();
+    if (loc.isValid())
+        Core::EditorManager::openEditorAt(loc.filePath, loc.line, loc.column - 1);
+}
+
+void DiagnosticView::mouseDoubleClickEvent(QMouseEvent *event)
+{
+    openEditorForCurrentIndex();
+    DetailedErrorView::mouseDoubleClickEvent(event);
+}
+
+} // namespace Internal
+} // namespace Cppcheck
+
+//#include "clangtoolsdiagnosticview.moc"