diff options
| author | Artem Sokolovskii <artem.sokolovskii@qt.io> | 2022-05-05 15:51:12 +0200 |
|---|---|---|
| committer | Artem Sokolovskii <artem.sokolovskii@qt.io> | 2022-05-09 13:30:46 +0000 |
| commit | dea72a4003f6ec4a2811c5be9675553db3d34544 (patch) | |
| tree | 534908b0520510fbc10afed50c73c28f37fdb079 /src/plugins/cppeditor/cppmodelmanager_test.cpp | |
| parent | 0a875d40ba9a518a2bbc81f5c30075f25566e0fa (diff) | |
| download | qt-creator-dea72a4003f6ec4a2811c5be9675553db3d34544.tar.gz | |
CppEditor: Remove foreach / Q_FOREACH usage part 2
Task-number: QTCREATORBUG-27464
Change-Id: I352bf37bd017e7381fbd7b050fbb55c9a73bd668
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Diffstat (limited to 'src/plugins/cppeditor/cppmodelmanager_test.cpp')
| -rw-r--r-- | src/plugins/cppeditor/cppmodelmanager_test.cpp | 26 |
1 files changed, 13 insertions, 13 deletions
diff --git a/src/plugins/cppeditor/cppmodelmanager_test.cpp b/src/plugins/cppeditor/cppmodelmanager_test.cpp index cfe552643a..2087d671cb 100644 --- a/src/plugins/cppeditor/cppmodelmanager_test.cpp +++ b/src/plugins/cppeditor/cppmodelmanager_test.cpp @@ -91,7 +91,7 @@ QStringList toAbsolutePaths(const QStringList &relativePathList, const TemporaryCopiedDir &temporaryDir) { QStringList result; - foreach (const QString &file, relativePathList) + for (const QString &file : relativePathList) result << temporaryDir.absolutePath(file.toUtf8()); return result; } @@ -108,7 +108,7 @@ public: void create(const QString &name, const QString &dir, const QStringList &files) { const MyTestDataDir projectDir(dir); - foreach (const QString &file, files) + for (const QString &file : files) projectFiles << projectDir.file(file); RawProjectPart rpp; @@ -489,7 +489,7 @@ void ModelManagerTest::testRefreshTimeStampModifiedIfSourcefilesChange() QCOMPARE(refreshedFiles.size(), initialProjectFiles.size()); snapshot = mm->snapshot(); - foreach (const QString &file, initialProjectFiles) { + for (const QString &file : qAsConst(initialProjectFiles)) { QVERIFY(refreshedFiles.contains(file)); QVERIFY(snapshot.contains(file)); } @@ -518,7 +518,7 @@ void ModelManagerTest::testRefreshTimeStampModifiedIfSourcefilesChange() QCOMPARE(refreshedFiles.size(), finalProjectFiles.size()); snapshot = mm->snapshot(); - foreach (const QString &file, finalProjectFiles) { + for (const QString &file : qAsConst(finalProjectFiles)) { QVERIFY(refreshedFiles.contains(file)); QVERIFY(snapshot.contains(file)); } @@ -569,7 +569,7 @@ void ModelManagerTest::testSnapshotAfterTwoProjects() QCOMPARE(refreshedFiles, Utils::toSet(project1.projectFiles)); const int snapshotSizeAfterProject1 = mm->snapshot().size(); - foreach (const QString &file, project1.projectFiles) + for (const QString &file : qAsConst(project1.projectFiles)) QVERIFY(mm->snapshot().contains(file)); // Project 2 @@ -584,9 +584,9 @@ void ModelManagerTest::testSnapshotAfterTwoProjects() QVERIFY(snapshotSizeAfterProject2 > snapshotSizeAfterProject1); QVERIFY(snapshotSizeAfterProject2 >= snapshotSizeAfterProject1 + project2.projectFiles.size()); - foreach (const QString &file, project1.projectFiles) + for (const QString &file : qAsConst(project1.projectFiles)) QVERIFY(mm->snapshot().contains(file)); - foreach (const QString &file, project2.projectFiles) + for (const QString &file : qAsConst(project2.projectFiles)) QVERIFY(mm->snapshot().contains(file)); } @@ -1014,7 +1014,7 @@ void ModelManagerTest::testRenameIncludes() // Copy test files to a temporary directory QSet<QString> sourceFiles; - foreach (const QString &fileName, fileNames) { + for (const QString &fileName : qAsConst(fileNames)) { const QString &file = workingDir.filePath(fileName); QVERIFY(QFile::copy(testDir.file(fileName), file)); // Saving source file names for the model manager update, @@ -1027,7 +1027,7 @@ void ModelManagerTest::testRenameIncludes() modelManager->updateSourceFiles(sourceFiles).waitForFinished(); QCoreApplication::processEvents(); CPlusPlus::Snapshot snapshot = modelManager->snapshot(); - foreach (const QString &sourceFile, sourceFiles) + for (const QString &sourceFile : qAsConst(sourceFiles)) QCOMPARE(snapshot.allIncludesForDocument(sourceFile), QSet<QString>() << oldHeader); // Renaming the header @@ -1039,7 +1039,7 @@ void ModelManagerTest::testRenameIncludes() modelManager->updateSourceFiles(sourceFiles).waitForFinished(); QCoreApplication::processEvents(); snapshot = modelManager->snapshot(); - foreach (const QString &sourceFile, sourceFiles) + for (const QString &sourceFile : qAsConst(sourceFiles)) QCOMPARE(snapshot.allIncludesForDocument(sourceFile), QSet<QString>() << newHeader); } @@ -1072,7 +1072,7 @@ void ModelManagerTest::testRenameIncludesInEditor() // Copy test files to a temporary directory QSet<QString> sourceFiles; - foreach (const QString &fileName, fileNames) { + for (const QString &fileName : fileNames) { const QString &file = workingDir.filePath(fileName); QVERIFY(QFile::copy(testDir.file(fileName), file)); // Saving source file names for the model manager update, @@ -1085,7 +1085,7 @@ void ModelManagerTest::testRenameIncludesInEditor() modelManager->updateSourceFiles(sourceFiles).waitForFinished(); QCoreApplication::processEvents(); CPlusPlus::Snapshot snapshot = modelManager->snapshot(); - foreach (const QString &sourceFile, sourceFiles) + for (const QString &sourceFile : qAsConst(sourceFiles)) QCOMPARE(snapshot.allIncludesForDocument(sourceFile), QSet<QString>() << headerWithPragmaOnce); // Open a file in the editor @@ -1163,7 +1163,7 @@ void ModelManagerTest::testRenameIncludesInEditor() modelManager->updateSourceFiles(sourceFiles).waitForFinished(); QCoreApplication::processEvents(); snapshot = modelManager->snapshot(); - foreach (const QString &sourceFile, sourceFiles) + for (const QString &sourceFile : qAsConst(sourceFiles)) QCOMPARE(snapshot.allIncludesForDocument(sourceFile), QSet<QString>() << renamedHeaderWithPragmaOnce); } |
