diff options
| author | Christian Kandeler <christian.kandeler@qt.io> | 2021-01-29 10:18:31 +0100 |
|---|---|---|
| committer | Christian Kandeler <christian.kandeler@qt.io> | 2021-01-29 14:21:46 +0000 |
| commit | aae3ce15aa72631e290b4eb6d0e163706b10390b (patch) | |
| tree | 2231a0b27e6f9b97a9dcd350bcfffed62edd52a8 /src/plugins/cppeditor/cppquickfix_test.cpp | |
| parent | fa260e00eded51b313a9b8b1621162f359156027 (diff) | |
| download | qt-creator-aae3ce15aa72631e290b4eb6d0e163706b10390b.tar.gz | |
CplusPlus: Fix minimal name construction
... when using declarations are involved.
Second attempt.
I have a suspicion that this is not the "correct" approach, however:
a) It appears to fix the problem.
b) It does not break any tests.
c) It's rather high in the call tree, so there's a low likelihood
of breaking something else.
d) Considering the hacky-looking pre-existing code dealing with
using declarations (e.g. LookupContext::lookupByUsing()),
it seems quite possible that there is no "correct" way with
the current infrastructure.
Fixes: QTCREATORBUG-14524
Change-Id: I28c6e53137c21ce158bbd03b92b3db39146116d5
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Diffstat (limited to 'src/plugins/cppeditor/cppquickfix_test.cpp')
| -rw-r--r-- | src/plugins/cppeditor/cppquickfix_test.cpp | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/src/plugins/cppeditor/cppquickfix_test.cpp b/src/plugins/cppeditor/cppquickfix_test.cpp index deeb31ff5e..91f6df74b4 100644 --- a/src/plugins/cppeditor/cppquickfix_test.cpp +++ b/src/plugins/cppeditor/cppquickfix_test.cpp @@ -4322,7 +4322,6 @@ void Foo::otherFunc() QuickFixOperationTest(testDocuments, &factory); } -// FIXME: QTCREATORBUG-14524. void CppEditorPlugin::test_quickfix_InsertDefFromDecl_usingDecl() { QList<QuickFixTestDocument::Ptr> testDocuments; @@ -4347,7 +4346,7 @@ void @func(const S &s); expected = R"( #include "file.h" -void func(const N::S &s) +void func(const S &s) { } @@ -4376,7 +4375,7 @@ void @func(const N1::S &s); expected = R"( #include "file.h" -void func(const N1::N2::S &s) +void func(const N1::S &s) { } |