diff options
author | Marco Bubke <marco.bubke@qt.io> | 2017-02-07 15:00:38 +0100 |
---|---|---|
committer | Marco Bubke <marco.bubke@qt.io> | 2017-09-14 15:23:56 +0000 |
commit | b6e12f4a1c2a8dbc7a672f0cf42ea76ece71b10d (patch) | |
tree | 81550e7fce5053ecb1ead60ddf59534d44517a87 /src/plugins/cpptools/builtineditordocumentparser.cpp | |
parent | 3adb71d45ebebd8c8fc2ec6beeb7a5ee67d64e4e (diff) | |
download | qt-creator-b6e12f4a1c2a8dbc7a672f0cf42ea76ece71b10d.tar.gz |
Convert macros from plain QByteArray to a vector of structs
The old code model expected the macros as C++ formatted text
("#define Foo 42) but newer targets like the Clang codemodel expect key
value arguments like "-DFoo=42". So instead of parsing the text again and
again we use an abstract data description.
Task-number: QTCREATORBUG-17915
Change-Id: I0179fd13c48a581e91ee79bba9d42d501c26f19f
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Diffstat (limited to 'src/plugins/cpptools/builtineditordocumentparser.cpp')
-rw-r--r-- | src/plugins/cpptools/builtineditordocumentparser.cpp | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/plugins/cpptools/builtineditordocumentparser.cpp b/src/plugins/cpptools/builtineditordocumentparser.cpp index ac3cf3ee2a..3fb407cb2d 100644 --- a/src/plugins/cpptools/builtineditordocumentparser.cpp +++ b/src/plugins/cpptools/builtineditordocumentparser.cpp @@ -26,6 +26,7 @@ #include "builtineditordocumentparser.h" #include "cppsourceprocessor.h" +#include <projectexplorer/projectmacro.h> #include <projectexplorer/projectexplorerconstants.h> #include <utils/qtcassert.h> @@ -91,9 +92,9 @@ void BuiltinEditorDocumentParser::updateImpl(const QFutureInterface<void> &futur } if (const ProjectPart::Ptr part = baseState.projectPartInfo.projectPart) { - configFile += part->toolchainDefines; + configFile += ProjectExplorer::Macro::toByteArray(part->toolChainMacros); configFile += overwrittenToolchainDefines(*part.data()); - configFile += part->projectDefines; + configFile += ProjectExplorer::Macro::toByteArray(part->projectMacros); if (!part->projectConfigFile.isEmpty()) configFile += ProjectPart::readProjectConfigFile(part); headerPaths = part->headerPaths; |