diff options
author | Christian Kandeler <christian.kandeler@qt.io> | 2020-08-24 10:46:58 +0200 |
---|---|---|
committer | Christian Kandeler <christian.kandeler@qt.io> | 2020-08-24 10:18:30 +0000 |
commit | d65ef60ea24a25e636f5a51b51192abbc883da12 (patch) | |
tree | d8b0c76370a9f3cdcff0ca719cb7f350bafe26c0 /src/plugins/cpptools/compileroptionsbuilder.h | |
parent | 643c9405bdf32f7df6037f8c6de51f2b3bdd098c (diff) | |
download | qt-creator-d65ef60ea24a25e636f5a51b51192abbc883da12.tar.gz |
clang: Fix include/resource dir confusion
The getClangResourceDirAndVersion() function in ClangTools could return
the actual resource dir or the include dir, depending on the input. This
mistake happened because of misleading names spread all around the code.
Now the function returns what it says, and the other names are accurate
as well.
Change-Id: I0a8600857ee7b9fafb16256e0d1ad203ac3273d2
Reviewed-by: David Schulz <david.schulz@qt.io>
Diffstat (limited to 'src/plugins/cpptools/compileroptionsbuilder.h')
-rw-r--r-- | src/plugins/cpptools/compileroptionsbuilder.h | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/src/plugins/cpptools/compileroptionsbuilder.h b/src/plugins/cpptools/compileroptionsbuilder.h index ee7e373312..cfaeecdea8 100644 --- a/src/plugins/cpptools/compileroptionsbuilder.h +++ b/src/plugins/cpptools/compileroptionsbuilder.h @@ -45,14 +45,13 @@ CPPTOOLS_EXPORT QStringList createLanguageOptionGcc(ProjectFile::Kind fileKind, class CPPTOOLS_EXPORT CompilerOptionsBuilder { public: - CompilerOptionsBuilder( - const ProjectPart &projectPart, + CompilerOptionsBuilder(const ProjectPart &projectPart, UseSystemHeader useSystemHeader = UseSystemHeader::No, UseTweakedHeaderPaths useTweakedHeaderPaths = UseTweakedHeaderPaths::No, UseLanguageDefines useLanguageDefines = UseLanguageDefines::No, UseBuildSystemWarnings useBuildSystemWarnings = UseBuildSystemWarnings::No, const QString &clangVersion = QString(), - const QString &clangResourceDirectory = QString()); + const QString &clangIncludeDirectory = QString()); QStringList build(ProjectFile::Kind fileKind, UsePrecompiledHeaders usePrecompiledHeaders); QStringList options() const { return m_options; } @@ -112,7 +111,7 @@ private: const UseBuildSystemWarnings m_useBuildSystemWarnings; const QString m_clangVersion; - const QString m_clangResourceDirectory; + const QString m_clangIncludeDirectory; struct { QStringList flags; |