diff options
author | Nikolai Kosjar <nikolai.kosjar@digia.com> | 2013-03-18 14:58:46 +0100 |
---|---|---|
committer | Nikolai Kosjar <nikolai.kosjar@digia.com> | 2013-03-19 14:12:11 +0100 |
commit | 947207c8020f6de25077481538e2855dc643c55e (patch) | |
tree | 0f5a11d913545b3e0b032bc44a5da28299516438 /src/plugins/cpptools/cppcompletion_test.cpp | |
parent | 7f61d11311187b45e1bff859cd097eab59342cc7 (diff) | |
download | qt-creator-947207c8020f6de25077481538e2855dc643c55e.tar.gz |
C++: Fix dangling IDocument* in CppCompletionAssistProcessor
Steps to reproduce the crash:
1. Open some long file, e.g. botan.cpp
2. Trigger completion and close editor immediately
The IDocument pointer was only used to reference the file name. Instead
of passing an IDocument* to the IAssistInterface, pass the file name.
Change-Id: Iafce9b818806a77968a10541114bc9b7c8665f11
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
Reviewed-by: David Schulz <david.schulz@digia.com>
Diffstat (limited to 'src/plugins/cpptools/cppcompletion_test.cpp')
-rw-r--r-- | src/plugins/cpptools/cppcompletion_test.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/plugins/cpptools/cppcompletion_test.cpp b/src/plugins/cpptools/cppcompletion_test.cpp index 6e35e263da..823a478fe4 100644 --- a/src/plugins/cpptools/cppcompletion_test.cpp +++ b/src/plugins/cpptools/cppcompletion_test.cpp @@ -77,7 +77,7 @@ static QStringList getCompletions(TestData &data, bool *replaceAccessOperator = QStringList completions; CppCompletionAssistInterface *ai = new CppCompletionAssistInterface(data.editor->document(), data.pos, - data.editor->editorDocument(), ExplicitlyInvoked, + data.editor->editorDocument()->fileName(), ExplicitlyInvoked, data.snapshot, QStringList(), QStringList()); CppCompletionAssistProcessor processor; IAssistProposal *proposal = processor.perform(ai); |