diff options
author | Alessandro Portale <alessandro.portale@qt.io> | 2019-01-14 01:40:53 +0100 |
---|---|---|
committer | Alessandro Portale <alessandro.portale@qt.io> | 2019-01-21 09:00:18 +0000 |
commit | 1d3d18a96988eb091b207103f18c9fbba505013a (patch) | |
tree | ea96a5524d5dbda96447455a9152484e54ea6e3b /src/plugins/cpptools/cpplocalsymbols_test.cpp | |
parent | 845af928896ba1ef1bb7259766913ea7f4c35cd9 (diff) | |
download | qt-creator-1d3d18a96988eb091b207103f18c9fbba505013a.tar.gz |
CppTools: modernize
Change-Id: Iaf02e4d026f1ac8b216833d83cd7a735e21ff60a
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Diffstat (limited to 'src/plugins/cpptools/cpplocalsymbols_test.cpp')
-rw-r--r-- | src/plugins/cpptools/cpplocalsymbols_test.cpp | 17 |
1 files changed, 8 insertions, 9 deletions
diff --git a/src/plugins/cpptools/cpplocalsymbols_test.cpp b/src/plugins/cpptools/cpplocalsymbols_test.cpp index 9183c9bfcd..7ee8ad1723 100644 --- a/src/plugins/cpptools/cpplocalsymbols_test.cpp +++ b/src/plugins/cpptools/cpplocalsymbols_test.cpp @@ -38,9 +38,8 @@ namespace { class FindFirstFunctionDefinition: protected CPlusPlus::ASTVisitor { public: - FindFirstFunctionDefinition(CPlusPlus::TranslationUnit *translationUnit) + explicit FindFirstFunctionDefinition(CPlusPlus::TranslationUnit *translationUnit) : ASTVisitor(translationUnit) - , m_definition(0) {} CPlusPlus::FunctionDefinitionAST *operator()() @@ -50,7 +49,7 @@ public: } private: - bool preVisit(CPlusPlus::AST *ast) + bool preVisit(CPlusPlus::AST *ast) override { if (CPlusPlus::FunctionDefinitionAST *f = ast->asFunctionDefinition()) { m_definition = f; @@ -60,20 +59,20 @@ private: } private: - CPlusPlus::FunctionDefinitionAST *m_definition; + CPlusPlus::FunctionDefinitionAST *m_definition = nullptr; }; struct Result { - Result() : line(0), column(0), length(0) {} + Result() = default; Result(const QByteArray &name, unsigned line, unsigned column, unsigned length) : name(name), line(line), column(column), length(length) {} QByteArray name; - unsigned line; - unsigned column; - unsigned length; + unsigned line = 0; + unsigned column = 0; + unsigned length = 0; bool operator==(const Result &other) const { @@ -139,7 +138,7 @@ void CppToolsPlugin::test_cpplocalsymbols_data() QTest::addColumn<QByteArray>("source"); QTest::addColumn<QList<Result>>("expectedUses"); - typedef QByteArray _; + using _ = QByteArray; QTest::newRow("basic") << _("int f(int arg)\n" |