diff options
| author | Jarek Kobus <jaroslaw.kobus@qt.io> | 2021-03-09 13:53:34 +0100 |
|---|---|---|
| committer | Jarek Kobus <jaroslaw.kobus@qt.io> | 2021-03-15 16:37:40 +0000 |
| commit | 3ab93592c35c4bb9f87be809ce858e6ba48003c1 (patch) | |
| tree | f7f32c1fce756a689142864e84d87f0a232012a8 /src/plugins/cpptools/cpplocatordata.cpp | |
| parent | 9d9ac537e8686a1625785fa0954049b356c07772 (diff) | |
| download | qt-creator-3ab93592c35c4bb9f87be809ce858e6ba48003c1.tar.gz | |
CppLocatorData: Don't use recursive mutex
Don't use recursive mutex in CppLocatorData class,
as this is more expensive to construct than simple
QMutex. Refactor the code so that every call to
flushPendingDocument() is done with already locked
m_pendingDocumentsMutex. This eliminates the need
for recursive mutex.
Remove unused allIndexItems() method.
Change-Id: Ic7cb45bc3301d83768e69ee52f84ae159cb731a5
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Diffstat (limited to 'src/plugins/cpptools/cpplocatordata.cpp')
| -rw-r--r-- | src/plugins/cpptools/cpplocatordata.cpp | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/src/plugins/cpptools/cpplocatordata.cpp b/src/plugins/cpptools/cpplocatordata.cpp index be2b948a96..3154f66ddb 100644 --- a/src/plugins/cpptools/cpplocatordata.cpp +++ b/src/plugins/cpptools/cpplocatordata.cpp @@ -86,7 +86,6 @@ void CppLocatorData::onAboutToRemoveFiles(const QStringList &files) void CppLocatorData::flushPendingDocument(bool force) const { // TODO: move this off the UI thread and into a future. - QMutexLocker locker(&m_pendingDocumentsMutex); if (!force && m_pendingDocuments.size() < MaxPendingDocuments) return; if (m_pendingDocuments.isEmpty()) @@ -98,12 +97,3 @@ void CppLocatorData::flushPendingDocument(bool force) const m_pendingDocuments.clear(); m_pendingDocuments.reserve(MaxPendingDocuments); } - -QList<IndexItem::Ptr> CppLocatorData::allIndexItems( - const QHash<QString, QList<IndexItem::Ptr>> &items) const -{ - QList<IndexItem::Ptr> result; - for (const QList<IndexItem::Ptr> &subItems : items) - result.append(subItems); - return result; -} |