diff options
author | Fawzi Mohamed <fawzi.mohamed@digia.com> | 2014-01-23 14:28:31 +0100 |
---|---|---|
committer | Fawzi Mohamed <fawzi.mohamed@digia.com> | 2014-02-19 21:18:58 +0100 |
commit | d24cb60d487e2241c8364b83658f31178305176a (patch) | |
tree | 2702c6f07ecca6a11c194b5352ab622dd55dc783 /src/plugins/cpptools/cppmodelmanager.cpp | |
parent | bf989b75a212b6a39f5a910ca78ad84f50e71f00 (diff) | |
download | qt-creator-d24cb60d487e2241c8364b83658f31178305176a.tar.gz |
qml: moving most of ModelManager logic to ModelManageInterface
Currently ModelManager contains lot logic, but as it sits in QmlJSTools
it is not possible to use it in standalone tests.
Moving most of the logic to ModelManagerInterface (and cleanup)
to allow better testing, and refactoring.
This introduces a dependency of the qmljs lib on the cplusplus lib
Also a (small) part of the CppTool::ModelManagerInterface has been
moved to CPlusPlus::CppModelManagerBase to remove the dependency on
CppTools to gather the Qml types exposed from C++.
Change-Id: Icad7fe96dfd0f1a2b1058d82bd98c77c40aa5e9d
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@digia.com>
Diffstat (limited to 'src/plugins/cpptools/cppmodelmanager.cpp')
-rw-r--r-- | src/plugins/cpptools/cppmodelmanager.cpp | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/plugins/cpptools/cppmodelmanager.cpp b/src/plugins/cpptools/cppmodelmanager.cpp index f4a5329b33..5a0e96a369 100644 --- a/src/plugins/cpptools/cppmodelmanager.cpp +++ b/src/plugins/cpptools/cppmodelmanager.cpp @@ -999,7 +999,7 @@ void CppModelManager::enableGarbageCollector(bool enable) m_enableGC = enable; } -void CppModelManager::setExtraDiagnostics(const QString &fileName, +bool CppModelManager::setExtraDiagnostics(const QString &fileName, const QString &kind, const QList<Document::DiagnosticMessage> &diagnostics) { @@ -1013,9 +1013,10 @@ void CppModelManager::setExtraDiagnostics(const QString &fileName, foreach (CppEditorSupport *editorSupport, cppEditorSupports) { if (editorSupport->fileName() == fileName) { editorSupport->setExtraDiagnostics(kind, diagnostics); - break; + return true; } } + return false; } void CppModelManager::setIfdefedOutBlocks(const QString &fileName, |