CppTools: Turn some classes into pure value types

ProjectInfo, ProjectPart and ProjectUpdateInfo used to carry pointers
to Project and/or Toolchain, even though they were used in contexts
where these pointers were either unsafe to access or not guaranteed to
be valid anymore, which made their use difficult and error-prone.
We turn these classes into pure value types by copying in all relevant
information before the first async operation takes place.

Fixes: QTCREATORBUG-25678
Change-Id: I1914b0dbda6c7dfba6c95e5e92f2d69977755590
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>

1 files changed, 1 insertions, 2 deletions

diff --git a/src/plugins/cpptools/cppprojectupdater.h b/src/plugins/cpptools/cppprojectupdater.h
index c356ab63d1..a76122d4b4 100644
--- a/src/plugins/cpptools/cppprojectupdater.h
+++ b/src/plugins/cpptools/cppprojectupdater.h
@@ -63,7 +63,6 @@ public:
     void cancel() override;
 
 private:
-    void onToolChainRemoved(ProjectExplorer::ToolChain *);
     void onProjectInfoGenerated();
     void checkForExtraCompilersFinished();
 
@@ -71,7 +70,7 @@ private:
     ProjectExplorer::ProjectUpdateInfo m_projectUpdateInfo;
     QList<QPointer<ProjectExplorer::ExtraCompiler>> m_extraCompilers;
 
-    QFutureWatcher<ProjectInfo> m_generateFutureWatcher;
+    QFutureWatcher<ProjectInfo::Ptr> m_generateFutureWatcher;
     bool m_isProjectInfoGenerated = false;
     QSet<QFutureWatcher<void> *> m_extraCompilersFutureWatchers;
     std::unique_ptr<QFutureInterface<void>> m_projectUpdateFutureInterface;