diff options
| author | Jarek Kobus <jaroslaw.kobus@qt.io> | 2020-11-09 11:33:30 +0100 |
|---|---|---|
| committer | Jarek Kobus <jaroslaw.kobus@qt.io> | 2020-11-09 15:25:13 +0000 |
| commit | 4c7032fb1e56a8816585dbd1748f799abaccdd65 (patch) | |
| tree | 266b434560285979c63086a23764c85caf4e45b4 /src/plugins/cpptools/cppprojectupdater.h | |
| parent | 91ad88205a231d88c0af6678af6dc5377b0d98d0 (diff) | |
| download | qt-creator-4c7032fb1e56a8816585dbd1748f799abaccdd65.tar.gz | |
Make CppProjectUdpater a final class
Silence the warning:
"Call to virtual method 'CppProjectUdpater::cancel'
during destruction bypasses virtual dispatch".
CppProjectUpdater's d'tor calls cancelAndWaitForFinished(), and
the latter calls in turn virtual cancel() method.
As long as we don't have subclasses of CppProjectUdpater,
calling a virtual cancel() from the d'tor should be safe.
Change-Id: If2ebe6a190649319401d4e4b0f6977f547c51dac
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Diffstat (limited to 'src/plugins/cpptools/cppprojectupdater.h')
| -rw-r--r-- | src/plugins/cpptools/cppprojectupdater.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/plugins/cpptools/cppprojectupdater.h b/src/plugins/cpptools/cppprojectupdater.h index 5d95fa087c..8167b071cf 100644 --- a/src/plugins/cpptools/cppprojectupdater.h +++ b/src/plugins/cpptools/cppprojectupdater.h @@ -47,7 +47,7 @@ public: Q_INVOKABLE CppTools::CppProjectUpdaterInterface *create(); }; -class CPPTOOLS_EXPORT CppProjectUpdater : public QObject, public CppProjectUpdaterInterface +class CPPTOOLS_EXPORT CppProjectUpdater final : public QObject, public CppProjectUpdaterInterface { Q_OBJECT |