CppTools: modernize

Change-Id: Iaf02e4d026f1ac8b216833d83cd7a735e21ff60a
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

1 files changed, 10 insertions, 10 deletions

diff --git a/src/plugins/cpptools/cppselectionchanger.h b/src/plugins/cpptools/cppselectionchanger.h
index d205e2ce2e..487e8ff655 100644
--- a/src/plugins/cpptools/cppselectionchanger.h
+++ b/src/plugins/cpptools/cppselectionchanger.h
@@ -38,8 +38,8 @@ namespace CppTools {
 
 class ASTNodePositions {
 public:
-    ASTNodePositions() {}
-    ASTNodePositions(CPlusPlus::AST *_ast) : ast(_ast) {}
+    ASTNodePositions() = default;
+    explicit ASTNodePositions(CPlusPlus::AST *_ast) : ast(_ast) {}
     operator bool() const { return ast; }
 
     CPlusPlus::AST *ast = nullptr;
@@ -97,13 +97,13 @@ private:
                                               const QTextCursor &cursor,
                                               int startingFromNodeIndex = -1);
     ASTNodePositions findRelevantASTPositionsFromCursorWhenNodeIndexNotSet(
-            const QList<CPlusPlus::AST *> astPath,
+            const QList<CPlusPlus::AST *> &astPath,
             const QTextCursor &cursor);
     ASTNodePositions findRelevantASTPositionsFromCursorWhenWholeDocumentSelected(
-            const QList<CPlusPlus::AST *> astPath,
+            const QList<CPlusPlus::AST *> &astPath,
             const QTextCursor &cursor);
     ASTNodePositions findRelevantASTPositionsFromCursorFromPreviousNodeIndex(
-            const QList<CPlusPlus::AST *> astPath,
+            const QList<CPlusPlus::AST *> &astPath,
             const QTextCursor &cursor);
     bool shouldSkipASTNodeBasedOnPosition(const ASTNodePositions &positions,
                                           const QTextCursor &cursor) const;
@@ -115,11 +115,11 @@ private:
     QTextCursor m_initialChangeSelectionCursor;
     QTextCursor m_workingCursor;
     CPlusPlus::Document::Ptr m_doc;
-    CPlusPlus::TranslationUnit *m_unit;
-    Direction m_direction;
-    int m_changeSelectionNodeIndex;
-    int m_nodeCurrentStep;
-    bool m_inChangeSelection;
+    CPlusPlus::TranslationUnit *m_unit = nullptr;
+    Direction m_direction = ExpandSelection;
+    int m_changeSelectionNodeIndex = -1;
+    int m_nodeCurrentStep = -1;
+    bool m_inChangeSelection = false;
 };
 
 } // namespace CppTools