diff options
| author | hjk <hjk121@nokiamail.com> | 2013-01-31 11:39:11 +0100 |
|---|---|---|
| committer | hjk <hjk121@nokiamail.com> | 2013-01-31 11:59:15 +0100 |
| commit | 82ab15e403d7da3c02fa7aaa2ed824ff67191296 (patch) | |
| tree | c8d1b9254816a8212e0e39fc182636925952cbb9 /src/plugins/debugger/breakhandler.cpp | |
| parent | 174baf5ea1b47b44471f737dd29cd758763e2c1a (diff) | |
| download | qt-creator-82ab15e403d7da3c02fa7aaa2ed824ff67191296.tar.gz | |
Debugger: Avoid endless loop when setting breakpoint on functions
Change-Id: I3ead86ba50d1d68a46cdc58c06684b2ac8c091c0
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
Diffstat (limited to 'src/plugins/debugger/breakhandler.cpp')
| -rw-r--r-- | src/plugins/debugger/breakhandler.cpp | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/src/plugins/debugger/breakhandler.cpp b/src/plugins/debugger/breakhandler.cpp index 8e781f766b..7cbc998f11 100644 --- a/src/plugins/debugger/breakhandler.cpp +++ b/src/plugins/debugger/breakhandler.cpp @@ -1439,8 +1439,13 @@ bool BreakHandler::BreakpointItem::needsChange() const return true; if (data.command != response.command) return true; - if (data.lineNumber != response.lineNumber) + if (data.type == BreakpointByFileAndLine && data.lineNumber != response.lineNumber) return true; + // FIXME: Too strict, functions may have parameter lists, or not. + // if (data.type == BreakpointByFunction && data.functionName != response.functionName) + // return true; + // if (data.type == BreakpointByAddress && data.address != response.address) + // return true; return false; } |