diff options
| author | Jarek Kobus <jaroslaw.kobus@qt.io> | 2022-12-14 09:10:46 +0100 |
|---|---|---|
| committer | Jarek Kobus <jaroslaw.kobus@qt.io> | 2022-12-14 16:52:26 +0000 |
| commit | 042087ab1deb46da3288df1aae3bbda03bd7e433 (patch) | |
| tree | 0ea5b39b16082d5235af78109c53c0ae3413f4f0 /src/plugins/git/gitclient.cpp | |
| parent | ac7a582ca9769d641a1b7eaece360b6828ed70c7 (diff) | |
| download | qt-creator-042087ab1deb46da3288df1aae3bbda03bd7e433.tar.gz | |
DiffEditor: Simplify internals
Don't pass startupFile arg on every setDiffFiles.
Provide a setStartupFile() separate setter inside
DiffEditorDocument and call it directly from
DiffEditorController::setStartupFile().
Correct updateDescription() implementation.
Change-Id: Ie489431632bdabc61e2c692d09caf7b2e3990764
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Diffstat (limited to 'src/plugins/git/gitclient.cpp')
| -rw-r--r-- | src/plugins/git/gitclient.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/plugins/git/gitclient.cpp b/src/plugins/git/gitclient.cpp index fe8129e861..04970096ce 100644 --- a/src/plugins/git/gitclient.cpp +++ b/src/plugins/git/gitclient.cpp @@ -256,10 +256,10 @@ private: setupDiffProcessor(async, storage->m_stagedOutput + storage->m_unstagedOutput); }; const auto onProcessDiffDone = [this, storage](const AsyncTask<QList<FileData>> &async) { - setDiffFiles(async.result(), workingDirectory(), startupFile()); + setDiffFiles(async.result(), workingDirectory()); }; const auto onProcessDiffError = [this, storage](const AsyncTask<QList<FileData>> &) { - setDiffFiles({}, workingDirectory(), startupFile()); + setDiffFiles({}, workingDirectory()); }; const Group root { @@ -474,10 +474,10 @@ Tasking::Group ShowController::reloadRecipe() setupDiffProcessor(async, storage->m_diffOutput); }; const auto onProcessDiffDone = [this, storage](const AsyncTask<QList<FileData>> &async) { - setDiffFiles(async.result(), workingDirectory(), startupFile()); + setDiffFiles(async.result(), workingDirectory()); }; const auto onProcessDiffError = [this, storage](const AsyncTask<QList<FileData>> &) { - setDiffFiles({}, workingDirectory(), startupFile()); + setDiffFiles({}, workingDirectory()); }; const Group root { |