diff options
author | Jarek Kobus <jaroslaw.kobus@qt.io> | 2022-12-14 22:16:49 +0100 |
---|---|---|
committer | Jarek Kobus <jaroslaw.kobus@qt.io> | 2022-12-15 08:28:44 +0000 |
commit | 5aedb4ba563f4de30686fbe1dd18229ef57dbf6f (patch) | |
tree | c4f08b7beb61174718ef71e2892e2977b43fe8ae /src/plugins/git/gitclient.cpp | |
parent | ce161d0b16f498636e3e3adf74c8bae603b4c76b (diff) | |
download | qt-creator-5aedb4ba563f4de30686fbe1dd18229ef57dbf6f.tar.gz |
DiffEditorController: Simplify API
Get rid of VcsBaseDiffEditorController::setWorkingDirectory()
and rename DiffEditorController::setBaseDirectory() into
setWorkingDirectory(). Don't pass workingDirectory
inside setDiffFiles().
Change-Id: I6a3a02d5e3ddc23977ed2908cd8d7b8ed51a9ee0
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Diffstat (limited to 'src/plugins/git/gitclient.cpp')
-rw-r--r-- | src/plugins/git/gitclient.cpp | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/src/plugins/git/gitclient.cpp b/src/plugins/git/gitclient.cpp index 34c357b2c5..5235f8a21b 100644 --- a/src/plugins/git/gitclient.cpp +++ b/src/plugins/git/gitclient.cpp @@ -256,10 +256,10 @@ private: setupDiffProcessor(async, storage->m_stagedOutput + storage->m_unstagedOutput); }; const auto onProcessDiffDone = [this, storage](const AsyncTask<QList<FileData>> &async) { - setDiffFiles(async.result(), workingDirectory()); + setDiffFiles(async.result()); }; const auto onProcessDiffError = [this, storage](const AsyncTask<QList<FileData>> &) { - setDiffFiles({}, workingDirectory()); + setDiffFiles({}); }; const Group root { @@ -474,10 +474,10 @@ Tasking::Group ShowController::reloadRecipe() setupDiffProcessor(async, storage->m_diffOutput); }; const auto onProcessDiffDone = [this, storage](const AsyncTask<QList<FileData>> &async) { - setDiffFiles(async.result(), workingDirectory()); + setDiffFiles(async.result()); }; const auto onProcessDiffError = [this, storage](const AsyncTask<QList<FileData>> &) { - setDiffFiles({}, workingDirectory()); + setDiffFiles({}); }; const Group root { @@ -915,7 +915,7 @@ void GitClient::stage(DiffEditor::DiffEditorController *diffController, if (!patchFile.open()) return; - const FilePath baseDir = diffController->baseDirectory(); + const FilePath baseDir = diffController->workingDirectory(); QTextCodec *codec = EditorManager::defaultTextCodec(); const QByteArray patchData = codec ? codec->fromUnicode(patch) : patch.toLocal8Bit(); |