diff options
| author | Jarek Kobus <jaroslaw.kobus@qt.io> | 2022-07-12 15:40:47 +0200 |
|---|---|---|
| committer | Jarek Kobus <jaroslaw.kobus@qt.io> | 2022-07-13 16:01:28 +0000 |
| commit | 89e720104887c8dd3310cad347a36e59dc5dfb52 (patch) | |
| tree | 43c3bdd1998f89c3d7d583ef6b3e1fa9bf83dafe /src/plugins/git/gitplugin.cpp | |
| parent | ec48545628e6d97cb367094b25c851813159fc63 (diff) | |
| download | qt-creator-89e720104887c8dd3310cad347a36e59dc5dfb52.tar.gz | |
VcsBase: Hide VcsCommand class
Make it an implementation detail.
Introduce VcsBaseClient::createVcsCommand() method instead
for instantiating VcsCommands.
Replace all occuriences of VcsBase::VcsCommand in public API
with Utils::ShellCommand.
Change-Id: Ie438cc3a5e867b3ee8f9e935b56b2f16ea453f8a
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Diffstat (limited to 'src/plugins/git/gitplugin.cpp')
| -rw-r--r-- | src/plugins/git/gitplugin.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/plugins/git/gitplugin.cpp b/src/plugins/git/gitplugin.cpp index e8198bdbb9..857a3701dc 100644 --- a/src/plugins/git/gitplugin.cpp +++ b/src/plugins/git/gitplugin.cpp @@ -67,6 +67,7 @@ #include <utils/pathchooser.h> #include <utils/qtcassert.h> #include <utils/runextensions.h> +#include <utils/shellcommand.h> #include <utils/stringutils.h> #include <utils/utilsicons.h> @@ -74,7 +75,6 @@ #include <vcsbase/submitfilemodel.h> #include <vcsbase/vcsbaseeditor.h> #include <vcsbase/vcsbaseconstants.h> -#include <vcsbase/vcscommand.h> #include <vcsbase/basevcssubmiteditorfactory.h> #include <vcsbase/vcsoutputwindow.h> #include <vcsbase/cleandialog.h> @@ -1929,7 +1929,7 @@ ShellCommand *GitPluginPrivate::createInitialCheckoutCommand(const QString &url, QStringList args = {"clone", "--progress"}; args << extraArgs << url << localName; - auto command = new VcsBase::VcsCommand(baseDirectory, m_gitClient.processEnvironment()); + auto command = VcsBaseClient::createVcsCommand(baseDirectory, m_gitClient.processEnvironment()); command->addFlags(ShellCommand::SuppressStdErr); command->addJob({m_gitClient.vcsBinary(), args}, -1); return command; |