diff options
| author | Orgad Shaneh <orgad.shaneh@audiocodes.com> | 2018-10-01 21:56:17 +0300 |
|---|---|---|
| committer | Orgad Shaneh <orgads@gmail.com> | 2018-10-01 19:21:39 +0000 |
| commit | 681297ad7e7c5bb6814befbac3a8d082820c35e8 (patch) | |
| tree | 18bb91bc5675608c38327030fcbd61ac442be7c8 /src/plugins/git/gitversioncontrol.cpp | |
| parent | d585b85550797f1d6bb384b51c376ce871394255 (diff) | |
| download | qt-creator-681297ad7e7c5bb6814befbac3a8d082820c35e8.tar.gz | |
Git: Fix reading of gitfile
* QFile ctor does not open the file for read.
* Replace readLine with read(8) to avoid needless read.
This amends commit e9eeaf33b3a84b32b2ef31c964b8cbea738cac59.
Change-Id: I33c230497ad431091d7d6b271846f5af661b4e0d
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Diffstat (limited to 'src/plugins/git/gitversioncontrol.cpp')
| -rw-r--r-- | src/plugins/git/gitversioncontrol.cpp | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/src/plugins/git/gitversioncontrol.cpp b/src/plugins/git/gitversioncontrol.cpp index dc0607cbb7..e36a22239e 100644 --- a/src/plugins/git/gitversioncontrol.cpp +++ b/src/plugins/git/gitversioncontrol.cpp @@ -82,7 +82,10 @@ bool GitVersionControl::isVcsFileOrDirectory(const Utils::FileName &fileName) co return false; if (fileName.toFileInfo().isDir()) return true; - return QFile(fileName.toString()).readLine().startsWith("gitdir: "); + QFile file(fileName.toString()); + if (!file.open(QFile::ReadOnly)) + return false; + return file.read(8) == "gitdir: "; } bool GitVersionControl::isConfigured() const |