summaryrefslogtreecommitdiff
path: root/src/plugins/pythoneditor/pythoneditorplugin.cpp
diff options
context:
space:
mode:
authorhjk <hjk@qt.io>2018-05-03 18:15:49 +0200
committerhjk <hjk@qt.io>2018-06-05 15:08:29 +0000
commit0fbb2839f92b001414d1eed2ae2627cf421fd34f (patch)
treeceffb29d5f2e3faf2fc12f5dc4612af652bf32e3 /src/plugins/pythoneditor/pythoneditorplugin.cpp
parentd384e2398a21608282cb137aa039707a84c80b4e (diff)
downloadqt-creator-0fbb2839f92b001414d1eed2ae2627cf421fd34f.tar.gz
Remove ApplicationLauncher::Mode
The actual remaining use was to pop up a terminal in some setups where Mode == Console, with a default of Gui meaning "no console". In some downstream uses it was used set to Console (probably to mean "this helper process does not need a gui") but then luckily ignored when actually starting the helper processes. All cases where the console is useful and requested are nowadays RunWorkers belonging to RunConfigurations with a TerminalAspect, so they can directly get the relevant bit from their RunConfiguration without having it part of all StandardRunnables. Change-Id: I1368d5968da5cf672656aebf200ccac8d45335d0 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Diffstat (limited to 'src/plugins/pythoneditor/pythoneditorplugin.cpp')
-rw-r--r--src/plugins/pythoneditor/pythoneditorplugin.cpp1
1 files changed, 0 insertions, 1 deletions
diff --git a/src/plugins/pythoneditor/pythoneditorplugin.cpp b/src/plugins/pythoneditor/pythoneditorplugin.cpp
index 713416491f..ee20e088c9 100644
--- a/src/plugins/pythoneditor/pythoneditorplugin.cpp
+++ b/src/plugins/pythoneditor/pythoneditorplugin.cpp
@@ -299,7 +299,6 @@ Runnable PythonRunConfiguration::runnable() const
QtcProcess::addArg(&r.commandLineArguments, mainScript());
QtcProcess::addArgs(&r.commandLineArguments, extraAspect<ArgumentsAspect>()->arguments());
r.executable = extraAspect<InterpreterAspect>()->value();
- r.runMode = extraAspect<TerminalAspect>()->runMode();
r.environment = extraAspect<EnvironmentAspect>()->environment();
return r;
}