summaryrefslogtreecommitdiff
path: root/src/plugins/debugger/debuggerrunconfigurationaspect.cpp
Commit message (Collapse)AuthorAgeFilesLines
* Debugger: Fix compatibility for debugger engine statesChristian Stenger2023-05-091-0/+4
| | | | | | | | | ..when switching back to an older version of QC. Amends e0219fad4d9b540145739832a5d91045a3f3fd0e. Change-Id: I3662eb95cf1ae72f92688f12cc15b7a42fb1452c Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Layouting: Handle attach types via setterhjk2023-05-031-1/+2
| | | | | | Change-Id: I862f5cd109db3582b4f029787ec0cded2da39ce6 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* Utils: Remove one LayoutBuilder::addRow() overloadhjk2023-04-251-3/+3
| | | | | | | | | | The flexibility here is getting in the way later when trying to remove the dependency on aspects. Change-Id: I7221e80f2067292c7c80aead8f6d739fb7878f7e Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Debugger: Make debugger aspect more explicitChristian Stenger2023-04-201-137/+42
| | | | | | | | | | | | | | | | | There are basically 3 states for the decision whether to start a debugger or not. But these had been under-represented by just displaying 2 states. Enabled (checked) and disabled (unchecked) are obvious, but the default of Auto (represented as checked) is there for convenience of the user, but it has some drawbacks of failing its guess whether to enable the debugger or not. Turn the former check boxes into a tri-state combo boxes and explicitly display the consequences inside the summary. Task-number: QTCREATORBUG-28627 Change-Id: Ieffed5b227ae978555258097385d6e80dfad3ac6 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: hjk <hjk@qt.io>
* Debugger: Improve detection for the need of Qml DebuggerChristian Stenger2023-04-201-1/+17
| | | | | | | | | | | By default QC performs an educated guess whether to enable QML debugging or not. Improve this as the detection may fail and leave the user without a special hint depending on the project structure. Fixes: QTCREATORBUG-28627 Change-Id: Ibd461aff2bf9be7058bdf33c8740ef07a457c365 Reviewed-by: hjk <hjk@qt.io>
* Debugger: Put DebuggerRunConfigurationAspect into a DetailsWidgetAlessandro Portale2023-04-041-2/+31
| | | | | | | | | Mainly in order to put the fields into a visual frame. By default expanded. Fixes: QTCREATORBUG-27151 Change-Id: I9920d2c9f3872860e75e938ea90a9165aee5b92f Reviewed-by: hjk <hjk@qt.io>
* Utils: Flatten LayoutBuilder related hierarchieshjk2023-01-201-2/+2
| | | | | | | | | Originally the idea was to only expose LayoutBuilder, but we are getting more and more related items. Be consequent now, and have everything in Utils::Layouting, but not in nested classes. Change-Id: Ic0f98595882e5c60a25c30ec52df4a0ea79bc0ca Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* Remove GPL-3.0+ from license identifiersKai Köhne2023-01-061-1/+1
| | | | | | | | | | | | | | | Since we also license under GPL-3.0 WITH Qt-GPL-exception-1.0, this applies only to a hypothetical newer version of GPL, that doesn't exist yet. If such a version emerges, we can still decide to relicense... While at it, replace (deprecated) GPL-3.0 with more explicit GPL-3.0-only Change was done by running find . -type f -exec perl -pi -e "s/LicenseRef-Qt-Commercial OR GPL-3.0\+ OR GPL-3.0 WITH Qt-GPL-exception-1.0/LicenseRef-Qt-Commercial OR GPL-3.0-only WITH Qt-GPL-exception-1.0/g" {} \; Change-Id: I5097e6ce8d10233993ee30d7e25120e2659eb10b Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Remove unused includes of QFormLayoutJarek Kobus2022-11-181-1/+0
| | | | | | | Change-Id: Ia877cb57037342f2a7b332b29d9cb45e9b01c4bc Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: hjk <hjk@qt.io>
* Debugger: Use qtcEnvironmentVariable* instead of qEnvironmentVariable*Eike Ziller2022-08-311-1/+2
| | | | | | | | | | | | And instead of qgetenv. Takes Qt Creator's setting at "Environment > System > Environment" into account, which makes it easier on some platforms to set them (e.g. macOS), can be configured differently in different settings paths, and potentially can be changed at runtime (depending on usage). Change-Id: I3ea7623fb528e13a202afa2f89b00e5ee83962d8 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: David Schulz <david.schulz@qt.io>
* Use SPDX license identifiersLucie Gérard2022-08-261-24/+2
| | | | | | | | | Replace the current license disclaimer in files by a SPDX-License-Identifier. Task-number: QTBUG-67283 Change-Id: I708fd1f9f2b73d60f57cc3568646929117825813 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Utils: Make the second parameter to LayoutBuilder::attach() an enumhjk2022-07-261-1/+1
| | | | | | | | More explicit and more potential options (e.g. "treat grid as form") than a bool. Change-Id: I89413efe30410160c38b0e524ba64288dde2332e Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Debugger: Convert to Tr::trhjk2022-07-081-7/+9
| | | | | Change-Id: I5d2475c790851c68f9997ac6af72b5eaca58482d Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* ProjectExplorer: Copy more RunConfiguration data to RunControlhjk2022-04-121-0/+5
| | | | | | | | | | | | | | | | | | | The aspects are now responsible for defining what data needs to be copied and also to provide a suitable interface (kind of source-compatible to direct use) for access. The important change here is that RunControl::aspect(...) doesn't need to access RunControl::runConfiguration() in fully aspectified RunConfigurations anymore. In not-fully aspectified the runConfig access is moved to the user code to make the problem visible there. Long term, aspectification should be finished. As an additional benefit, the resolving of macros etc can now be done at the correct time. Change-Id: I690d9f8f696ce9b4efd42082ba3f81b514efcb77 Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Debugger: Improve layout in DebuggerLanguageAspectAlessandro Portale2022-01-201-0/+1
| | | | | | | Reduce the space between checkbox and info text label. Change-Id: I1654752124544184628eefe7fb5303613beff94e Reviewed-by: hjk <hjk@qt.io>
* Utils: Avoid intermediate widgets when using LayoutBuilderhjk2021-03-161-4/+2
| | | | | | | | | | | | In most cases, the layout constructed in the builder was set on a widget which in turn was put into a vbox in the actual widget. This is not necessary, but needs some re-ordering. Also make sure that using not-yet-parented widgets during layout construction does not cause visible artifacts. Change-Id: I75727a571da093d3131ea6fba467c2c646cdb6f1 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Utils: Use value/setValue instead of settings also for TriStateAspectshjk2021-02-221-1/+1
| | | | | Change-Id: I3d0a58917cd6682e14894e4320d166a1c8de6a9a Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Utils/ProjectExplorer: Move re-usabled bits of aspects to Utilshjk2020-09-231-2/+5
| | | | | | | | | | | Classes involved are BaseAspect and some derived classes, LayoutBuilder and VariableChooser. This is mostly mechanical, with various include/using changes to make it compile. Change-Id: I624a457f3555f102e541c4c71e33a9423af32250 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* ProjectExplorer: Rename Base*Aspect to *Aspecthjk2020-08-141-4/+4
| | | | | | | | | In most cases they are used directly, so there's not much Base* in that. Added the old name as alias as porting help for a while. Change-Id: I494a8a560b8996bcf74915ea3570b504df6a6b4c Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* ProjectExplorer: Add LayoutBuilder::addRow() convenience functionhjk2020-08-051-4/+4
| | | | | | | ... and use it in the DebuggerRunConfigurationAspect. Change-Id: I1079f1a307d5e4b286d32570c48299d296fa3061 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Merge remote-tracking branch 'origin/4.12'Eike Ziller2020-03-231-0/+1
|\ | | | | | | Change-Id: Ic741fdedc168430e5be6cb1645d9329dbc7a6b08
| * Run configuration: Fix layout of debugging optionsEike Ziller2020-03-201-0/+1
| | | | | | | | | | | | | | | | The differences in QFormLayout lead to unexpected results on macOS. Change-Id: If2b55a6233af3f8ac1afa6e3c586a16a263b32b5 Reviewed-by: Christian Stenger <christian.stenger@qt.io> Reviewed-by: hjk <hjk@qt.io>
* | DebuggerAspect: Simplify handling of Qml debuggingTobias Hunger2020-02-191-9/+7
|/ | | | | | | | | | | There should not be a need to have the linkQmlDebuggingLibrary Q_PROPERTY anymore. The property is added for the benefit of the DebuggerAspect, which can just check relevant BuildConfigurationAspect directly. Change-Id: Ic47ca9e26911e096564fe77bd14bebe959b4f116 Reviewed-by: Christian Stenger <christian.stenger@qt.io> Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* QmakeBuildConfiguration: Make use of Qt-related build aspectsChristian Kandeler2019-11-281-10/+3
| | | | | Change-Id: Ia14bb468fe75403839d8dcc8022c4f233c363f62 Reviewed-by: hjk <hjk@qt.io>
* Qmake: Make proper use of BuildDirectoryAspectChristian Kandeler2019-11-281-1/+2
| | | | | Change-Id: I439496c85f7e0f402ab038de6a8171dd2f7d2ffd Reviewed-by: hjk <hjk@qt.io>
* QtSupport: Add a QmlDebuggingAspectChristian Kandeler2019-11-251-0/+3
| | | | | | | | | ... and make use of it in the qbs build configuration. We cannot use it for qmake yet, because the build config there still has a custom, non-aspectified widget. Change-Id: Iacf902a2d9384d0074b10fdc98e082fa906fb6d6 Reviewed-by: hjk <hjk@qt.io>
* LayoutBuilder: Allow for more compact code at calling sitesChristian Kandeler2019-11-071-8/+4
| | | | | Change-Id: I12bb6dbfc138e03138b9a74d36e864d8ea36092f Reviewed-by: hjk <hjk@qt.io>
* Merge remote-tracking branch 'origin/4.11'Eike Ziller2019-10-281-0/+8
|\ | | | | | | Change-Id: I66389d88d5a60c6c86547b93cca945af42aa807b
| * Fix some memory leaksChristian Kandeler2019-10-231-0/+8
| | | | | | | | | | | | | | Found by Address Sanitizer. Change-Id: I989da71e24d737e36a88b83a1f382ce2d67e3307 Reviewed-by: hjk <hjk@qt.io>
* | ProjectExplorer: Prepare more flexibility to aspect layoutinghjk2019-10-181-21/+16
|/ | | | | | | | | | | | | | | | This hides the explicit use of a QFormLayout from the aspect interface in a new LayoutBuilder class. That currently works only on a QFormLayout in the back, but opens the possibility to use e.g. a QGridLayout as use on the Kits and some option pages. The aspects now only announce sub-widgets they like to add, actuall positioning is does by a new LayoutBuilder class, also cramming several widgets in an hbox in the right column of the QFormLayout is done there. Change-Id: I2b788192c465f2ab82261849d34e514697c5a491 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Debugger: (Sub-)Aspectify DebuggerRunConfigurationAspecthjk2019-10-021-130/+145
| | | | | Change-Id: If7fcc52a88dec02061c4e0cce4aa48d1b923ceb2 Reviewed-by: David Schulz <david.schulz@qt.io>
* Debugger: Remove QML port settings in run configshjk2019-09-301-50/+0
| | | | | | | Obsolete since the invention of PortGatherers. Change-Id: I34c80b2408213c2d6bd0d893763be4dffc2db7ea Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
* Debugger: Add a per-runconfig way to add debugger startup commandhjk2019-09-301-4/+23
| | | | | | Task-number: QTCREATORBUG-22979 Change-Id: I225b6cd1ee1dd3195bda3de4de72880d76e8cd37 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Remove usages of deprecated APIs of QLayoutSona Kurazyan2019-09-021-2/+2
| | | | | | | | | | Replaced: QLayout::setMargin() -> QLayout::setContentsMargins() QLayout::margin() -> QLayout::getContentsMargins() Task-number: QTBUG-76491 Change-Id: If28ef6910b3afe5d04e4746b74f9362a3e3b3c8e Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* connect() to ambiguous signals/slots: Replace static_cast with QOverloadAlessandro Portale2019-05-281-1/+1
| | | | | Change-Id: I473d7a2a16509cee944a2a21b022a3f6f02cfd8d Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Debugger: Remove mis-spelled and unused functionhjk2019-02-211-5/+0
| | | | | Change-Id: Iae81a29e75e289ceb44a845c5847152a7d1ad846 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* ProjectExplorer: Rename KitInformation to KitAspectChristian Kandeler2019-02-111-1/+1
| | | | | | | | | | | The name "KitInformation" does not properly convey the fact that it represents a certain *aspect* of a kit. The same goes for "KitConfigWidget", which in addition was inconsistent with "KitInformation". We now use "KitAspect" and "KitAspectWidget". Change-Id: I9804ee4cedc4d61fad533ea1dd4e4720e67fde97 Reviewed-by: hjk <hjk@qt.io>
* Help: Rename handleHelpRequest to showHelpUrlEike Ziller2019-01-251-1/+1
| | | | | | | Since that is what it does. Change-Id: I13ffe21cdb625a0df1313f2ff09bf84196f08768 Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
* Debugger: Strip QLatin1* where possibleOrgad Shaneh2018-10-131-11/+11
| | | | | Change-Id: Idcab23875b5dc2ecf55e3303f417b995e2252720 Reviewed-by: hjk <hjk@qt.io>
* ProjectExplorer: Update "generic" run configuration aspectshjk2018-09-131-2/+2
| | | | | | | | | None of the run configuration aspects that are added to each runconfig depend on the actual runconfig, only two need the target, the rest nothing at all. So use target as common denominator. Change-Id: I31829e63ac79d5c707bb068d73fc6a4687cb4c47 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
* ProjectExplorer: Remove IRunConfigurationAspect::runConfigurationhjk2018-09-131-3/+2
| | | | | | | | ... and adapt constructors to not take the now-unneeded RunConfiguration pointer. Change-Id: I53ff338f51334ff7b0c22d4bed92bfcfc8225ea7 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
* ProjectExplorer: Remove RunConfigWidget wrapper classhjk2018-09-131-4/+3
| | | | | | | | | | | | Not really needed, a QWidget does the job, too, and de-emphasizes then 'Run' bit. The display name is now taken always from the aspect, but that's what was the practically the case before, albeit with different implementations. Change all names to *[cC]onfigWidget* (in line with ISettingsAspect). Change-Id: Ida0409a2dd0b175dd5ce4202f9b9e94b3f2db421 Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
* Debugger: Store target pointer in DebuggerRunConfigurationAspecthjk2018-09-131-5/+5
| | | | | | | To avoid use of IRCAspect::runConfiguration(). Change-Id: Ic0518e368ec8caa4fdf7f9dc242123eedc893b4c Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
* Debugger: Avoid two uses of IRCAspect::runConfigurationhjk2018-09-121-7/+0
| | | | | | | The function is about to be removed. Change-Id: Ib18d1c51c18a9a979395910cdcd487575061dea0 Reviewed-by: David Schulz <david.schulz@qt.io>
* Debugger: ModernizeAlessandro Portale2018-07-251-2/+2
| | | | | | | | | | | | | modernize-use-auto modernize-use-nullptr modernize-use-override modernize-use-using modernize-use-default-member-init modernize-use-equals-default Change-Id: I91a6874f0d7b94e9079ab4ef07c23c60c80be9c0 Reviewed-by: Christian Stenger <christian.stenger@qt.io> Reviewed-by: hjk <hjk@qt.io>
* ProjectExplorer: Fix copying of RunConfigurationAspectshjk2017-11-101-6/+0
| | | | | | | | | | | Moving aspect data closer to real Value semantics fixes the regression introduced by 890c1906e. Task-number: QTCREATORBUG-19186 Task-number: QTCREATORBUG-19192 Change-Id: Ieaeef3995ae06a817f266c1e2514f9e5793bd4e8 Reviewed-by: David Schulz <david.schulz@qt.io> Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Unify projectexplorer language IDsUlf Hermann2017-01-301-3/+3
| | | | | | | | We don't need two IDs for C++ and the QmlJS ID should look the same as as the others. Change-Id: Ib9747f6b36a90bb652951d85eec69666615670c4 Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
* Use function objects for IRunConfigurationAspect::createConfigurationWidgethjk2016-04-221-5/+1
| | | | | Change-Id: Ief70ed8fc2731ad21b00c74407ff4b659d705caf Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
* RemoteLinux: Move portsUsedByDebugger() to DebuggerRunConfigurationAspecthjk2016-01-261-0/+10
| | | | | Change-Id: I0add29c3c69c4ba59cea159f32ca74be58bcee59 Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
* Update License according to agreement with Free Qt FoundationTobias Hunger2016-01-191-17/+12
| | | | | | | * Update files in src/plugins Change-Id: Ia5d77fad7d19d4bb3498e78661982f68729adb22 Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
View Lorry Controller Status